Stream: git-wasmtime

Topic: wasmtime / PR #2047 Fix `u8::MAX` -> `std::u8::MAX`.


view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2020 at 18:38):

cfallin requested alexcrichton for a review on PR #2047.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2020 at 18:38):

cfallin opened PR #2047 from fix-u8-max to main:

As per Carlo Kok on Zulip #cranelift, this breaks builds with stable
Rust pre-1.43, as core::u8::MAX was only stabilized then. We'd like to
support older versions if we can easily do so.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2020 at 19:21):

cfallin updated PR #2047 from fix-u8-max to main:

As per Carlo Kok on Zulip #cranelift, this breaks builds with stable
Rust pre-1.43, as core::u8::MAX was only stabilized then. We'd like to
support older versions if we can easily do so.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2020 at 19:59):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2020 at 19:59):

alexcrichton merged PR #2047.


Last updated: Dec 23 2024 at 13:07 UTC