Stream: git-wasmtime

Topic: wasmtime / PR #2047 Fix `u8::MAX` -> `std::u8::MAX`.

Wasmtime GitHub notifications bot (Jul 20 2020 at 18:38):

cfallin requested alexcrichton for a review on PR #2047.

Wasmtime GitHub notifications bot (Jul 20 2020 at 18:38):

cfallin opened PR #2047 from fix-u8-max to main:

As per Carlo Kok on Zulip #cranelift, this breaks builds with stable
Rust pre-1.43, as core::u8::MAX was only stabilized then. We'd like to
support older versions if we can easily do so.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 20 2020 at 19:21):

cfallin updated PR #2047 from fix-u8-max to main:

As per Carlo Kok on Zulip #cranelift, this breaks builds with stable
Rust pre-1.43, as core::u8::MAX was only stabilized then. We'd like to
support older versions if we can easily do so.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 20 2020 at 19:59):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Jul 20 2020 at 19:59):

alexcrichton merged PR #2047.

Last updated: Oct 23 2024 at 20:03 UTC