Stream: git-wasmtime

Topic: wasmtime / PR #2039 Fix a panic with `Func::new` and refe...

Wasmtime GitHub notifications bot (Jul 17 2020 at 16:11):

alexcrichton opened PR #2039 from fix-reference-types to main:

Currently Func::new will panic if one of the arguments of the function
is a reference type and the Store doesn't have reference types
enabled. This happens because cranelift isn't configure to enable stack
maps but the register allocators expects them to exist when reference
types are seen.

The fix here is to always enable reference types in cranelift for our
trampoline generation and Func::new. This should hopefully ensure that
trampolines are generated correctly and they'll just not be able to get
hooked up to an Instance because validation will prevent reference
types from being used elsewhere.

Wasmtime GitHub notifications bot (Jul 17 2020 at 16:14):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jul 17 2020 at 17:05):

alexcrichton merged PR #2039.

Last updated: Nov 22 2024 at 16:03 UTC