Wasmtime GitHub notifications bot (Jul 17 2020 at 13:58): Wasmtime GitHub notifications bot (Jul 17 2020 at 13:58):alexcrichton opened PR #2036 from fix-publish to main:
This commit updates our CI to verify that all crates are publish-able at
all times on every commit. During the 0.19.0 release we found another
case where the crates as they live in this repository weren't
publish-able, so the hope is that this no longer comes up again!The script added in this commit also takes the time/liberty to remove
the existing bump/publish scripts and instead replace them with one Rust
script originally sourced from wasm-bindgen. The intention of this
script is that it has three modes:
./publish bump- bumps version numbers which are sent as a PR to get
reviewed (probably with a changelog as well)
./publish verify- run on CI on every commit, builds every crate we
publish as if it's being published to crates.io, notably without raw
access to other crates in the repository.
./publish publish- publishes all crates to crates.io, passing the
--no-verifyflag to make this a much speedier process than it is
today.
Wasmtime GitHub notifications bot (Jul 17 2020 at 13:59):alexcrichton requested sunfishcode for a review on PR #2036.
Wasmtime GitHub notifications bot (Jul 17 2020 at 16:26):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Jul 17 2020 at 16:26):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Jul 17 2020 at 16:26):sunfishcode created PR Review Comment:
This usage comment is kind of a less-complete version of the docs in contributing-release-process.md. Would it make sense to just link to that document, and then make the comment here just briefly describe the CLI options?
Wasmtime GitHub notifications bot (Jul 17 2020 at 16:26):sunfishcode created PR Review Comment:
I may be missing something here, but I don't see what this function is supposed to be doing.
Wasmtime GitHub notifications bot (Jul 17 2020 at 19:04):alexcrichton updated PR #2036 from fix-publish to main:
This commit updates our CI to verify that all crates are publish-able at
all times on every commit. During the 0.19.0 release we found another
case where the crates as they live in this repository weren't
publish-able, so the hope is that this no longer comes up again!The script added in this commit also takes the time/liberty to remove
the existing bump/publish scripts and instead replace them with one Rust
script originally sourced from wasm-bindgen. The intention of this
script is that it has three modes:
./publish bump- bumps version numbers which are sent as a PR to get
reviewed (probably with a changelog as well)
./publish verify- run on CI on every commit, builds every crate we
publish as if it's being published to crates.io, notably without raw
access to other crates in the repository.
./publish publish- publishes all crates to crates.io, passing the
--no-verifyflag to make this a much speedier process than it is
today.
Wasmtime GitHub notifications bot (Jul 17 2020 at 19:05):alexcrichton updated PR #2036 from fix-publish to main:
This commit updates our CI to verify that all crates are publish-able at
all times on every commit. During the 0.19.0 release we found another
case where the crates as they live in this repository weren't
publish-able, so the hope is that this no longer comes up again!The script added in this commit also takes the time/liberty to remove
the existing bump/publish scripts and instead replace them with one Rust
script originally sourced from wasm-bindgen. The intention of this
script is that it has three modes:
./publish bump- bumps version numbers which are sent as a PR to get
reviewed (probably with a changelog as well)
./publish verify- run on CI on every commit, builds every crate we
publish as if it's being published to crates.io, notably without raw
access to other crates in the repository.
./publish publish- publishes all crates to crates.io, passing the
--no-verifyflag to make this a much speedier process than it is
today.
Wasmtime GitHub notifications bot (Jul 17 2020 at 19:05):alexcrichton created PR Review Comment:
I added some more documentation to this, but the intention is to basically figure out the next version number we're going to write down everywhere for each crate individually.
Wasmtime GitHub notifications bot (Jul 17 2020 at 19:05):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jul 17 2020 at 21:16):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Jul 17 2020 at 21:16):sunfishcode created PR Review Comment:
Ah, makes sense now. Thanks!
Wasmtime GitHub notifications bot (Jul 17 2020 at 21:16):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Jul 17 2020 at 21:19):alexcrichton merged PR #2036.
Last updated: Dec 23 2024 at 12:05 UTC