Stream: git-wasmtime

Topic: wasmtime / PR #2028 Enable reftypes tests on aarch64.


view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 21:50):

cfallin opened PR #2028 from enable-aarch64-reftype-tests to main:

With #1852, we now have support for reference types in the new backend
framework generally, and on aarch64 in particular. This PR removes the
test-ignore directive for reftypes tests on this platform.

This actually enables reftypes support for all platforms, rather than explicitly
only on x86_64, but going forward all new backends should include reftypes
support (since the new-backend framework does, and it just takes a few
machine-specific opcodes beyond that to do so), so I think it's best just to
set this baseline now.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 21:50):

cfallin requested alexcrichton for a review on PR #2028.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 21:57):

fitzgen edited PR #2028 from enable-aarch64-reftype-tests to main:

With #1852, we now have support for reference types in the new backend
framework generally, and on aarch64 in particular. This PR removes the
test-ignore directive for reftypes tests on this platform.

This actually enables reftypes support for all platforms, rather than explicitly
only on x86_64, but going forward all new backends should include reftypes
support (since the new-backend framework does, and it just takes a few
machine-specific opcodes beyond that to do so), so I think it's best just to
set this baseline now.

Fixes #1886

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 22:00):

cfallin updated PR #2028 from enable-aarch64-reftype-tests to main:

With #1852, we now have support for reference types in the new backend
framework generally, and on aarch64 in particular. This PR removes the
test-ignore directive for reftypes tests on this platform.

This actually enables reftypes support for all platforms, rather than explicitly
only on x86_64, but going forward all new backends should include reftypes
support (since the new-backend framework does, and it just takes a few
machine-specific opcodes beyond that to do so), so I think it's best just to
set this baseline now.

Fixes #1886

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 22:01):

fitzgen created PR Review Comment:

Tiny nitpick: these should be with the rest of the mod declarations above now (and sorted via cargo fmt).

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 22:01):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 22:02):

cfallin updated PR #2028 from enable-aarch64-reftype-tests to main:

With #1852, we now have support for reference types in the new backend
framework generally, and on aarch64 in particular. This PR removes the
test-ignore directive for reftypes tests on this platform.

This actually enables reftypes support for all platforms, rather than explicitly
only on x86_64, but going forward all new backends should include reftypes
support (since the new-backend framework does, and it just takes a few
machine-specific opcodes beyond that to do so), so I think it's best just to
set this baseline now.

Fixes #1886

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 22:02):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 22:02):

cfallin created PR Review Comment:

Done, thanks.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 13 2020 at 17:41):

cfallin closed without merge PR #2028.


Last updated: Dec 23 2024 at 13:07 UTC