Wasmtime GitHub notifications bot (Jul 15 2020 at 21:50): Wasmtime GitHub notifications bot (Jul 15 2020 at 21:50):cfallin opened PR #2028 from enable-aarch64-reftype-tests to main:
With #1852, we now have support for reference types in the new backend
framework generally, and on aarch64 in particular. This PR removes the
test-ignore directive for reftypes tests on this platform.This actually enables reftypes support for all platforms, rather than explicitly
only on x86_64, but going forward all new backends should include reftypes
support (since the new-backend framework does, and it just takes a few
machine-specific opcodes beyond that to do so), so I think it's best just to
set this baseline now.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 15 2020 at 21:50):cfallin requested alexcrichton for a review on PR #2028.
Wasmtime GitHub notifications bot (Jul 15 2020 at 21:57):fitzgen edited PR #2028 from enable-aarch64-reftype-tests to main:
With #1852, we now have support for reference types in the new backend
framework generally, and on aarch64 in particular. This PR removes the
test-ignore directive for reftypes tests on this platform.This actually enables reftypes support for all platforms, rather than explicitly
only on x86_64, but going forward all new backends should include reftypes
support (since the new-backend framework does, and it just takes a few
machine-specific opcodes beyond that to do so), so I think it's best just to
set this baseline now.Fixes #1886
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 15 2020 at 22:00):cfallin updated PR #2028 from enable-aarch64-reftype-tests to main:
With #1852, we now have support for reference types in the new backend
framework generally, and on aarch64 in particular. This PR removes the
test-ignore directive for reftypes tests on this platform.This actually enables reftypes support for all platforms, rather than explicitly
only on x86_64, but going forward all new backends should include reftypes
support (since the new-backend framework does, and it just takes a few
machine-specific opcodes beyond that to do so), so I think it's best just to
set this baseline now.Fixes #1886
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 15 2020 at 22:01):fitzgen created PR Review Comment:
Tiny nitpick: these should be with the rest of the
moddeclarations above now (and sorted viacargo fmt).
Wasmtime GitHub notifications bot (Jul 15 2020 at 22:01):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Jul 15 2020 at 22:02):cfallin updated PR #2028 from enable-aarch64-reftype-tests to main:
With #1852, we now have support for reference types in the new backend
framework generally, and on aarch64 in particular. This PR removes the
test-ignore directive for reftypes tests on this platform.This actually enables reftypes support for all platforms, rather than explicitly
only on x86_64, but going forward all new backends should include reftypes
support (since the new-backend framework does, and it just takes a few
machine-specific opcodes beyond that to do so), so I think it's best just to
set this baseline now.Fixes #1886
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 15 2020 at 22:02):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Jul 15 2020 at 22:02):cfallin created PR Review Comment:
Done, thanks.
Wasmtime GitHub notifications bot (Nov 13 2020 at 17:41):cfallin closed without merge PR #2028.
Last updated: Nov 22 2024 at 16:03 UTC