jgouly opened PR #2016 from saturating-math
to main
:
Copyright (c) 2020, Arm Limited.
cfallin submitted PR Review.
cfallin submitted PR Review.
cfallin created PR Review Comment:
Tiniest possible nit, but: we should be consistent with capitalization, so either
SQAdd
here, or change above toSqaddScalar
.
cfallin created PR Review Comment:
Pre-existing (my fault, sorry), but the subtract case is basically redundant with above, modulo the opcode itself -- could we merge them?
jgouly submitted PR Review.
jgouly created PR Review Comment:
@akirilov-arm has a patch (not yet on github) that is going to be renaming/moving the Scalar version. Then
Sqadd
will be consistent with the otherVecALUOp
variants.
cfallin submitted PR Review.
cfallin created PR Review Comment:
Sounds good, thanks.
jgouly updated PR #2016 from saturating-math
to main
:
Copyright (c) 2020, Arm Limited.
cfallin merged PR #2016.
Last updated: Dec 23 2024 at 12:05 UTC