Stream: git-wasmtime

Topic: wasmtime / PR #2016 arm64: Implement saturating SIMD arit...

Wasmtime GitHub notifications bot (Jul 14 2020 at 11:39):

jgouly opened PR #2016 from saturating-math to main:

Copyright (c) 2020, Arm Limited.

Wasmtime GitHub notifications bot (Jul 14 2020 at 16:02):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Jul 14 2020 at 16:02):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Jul 14 2020 at 16:02):

cfallin created PR Review Comment:

Tiniest possible nit, but: we should be consistent with capitalization, so either SQAdd here, or change above to SqaddScalar.

Wasmtime GitHub notifications bot (Jul 14 2020 at 16:02):

cfallin created PR Review Comment:

Pre-existing (my fault, sorry), but the subtract case is basically redundant with above, modulo the opcode itself -- could we merge them?

Wasmtime GitHub notifications bot (Jul 14 2020 at 16:18):

jgouly submitted PR Review.

Wasmtime GitHub notifications bot (Jul 14 2020 at 16:18):

jgouly created PR Review Comment:

@akirilov-arm has a patch (not yet on github) that is going to be renaming/moving the Scalar version. Then Sqadd will be consistent with the other VecALUOp variants.

Wasmtime GitHub notifications bot (Jul 14 2020 at 17:00):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Jul 14 2020 at 17:00):

cfallin created PR Review Comment:

Sounds good, thanks.

Wasmtime GitHub notifications bot (Jul 14 2020 at 17:19):

jgouly updated PR #2016 from saturating-math to main:

Copyright (c) 2020, Arm Limited.

Wasmtime GitHub notifications bot (Jul 14 2020 at 18:24):

cfallin merged PR #2016.

Last updated: Oct 23 2024 at 20:03 UTC