Stream: git-wasmtime

Topic: wasmtime / PR #2013 Update wasmparser to 0.59.0


view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2020 at 18:05):

alexcrichton opened PR #2013 from update-wasmparser to main:

This commit is intended to update wasmparser to 0.59.0. This primarily
includes bytecodealliance/wasm-tools#40 which is a large update to how
parsing and validation works. The impact on Wasmtime is pretty small at
this time, but over time I'd like to refactor the internals here to lean
more heavily on that upstream wasmparser refactoring.

For now, though, the intention is to get on the train of wasmparser's
latest main branch to ensure we get bug fixes and such.

As part of this update a few other crates and such were updated. This is
primarily to handle the new encoding of ref.is_null where the type is
not part of the instruction encoding any more.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2020 at 18:07):

alexcrichton updated PR #2013 from update-wasmparser to main:

This commit is intended to update wasmparser to 0.59.0. This primarily
includes bytecodealliance/wasm-tools#40 which is a large update to how
parsing and validation works. The impact on Wasmtime is pretty small at
this time, but over time I'd like to refactor the internals here to lean
more heavily on that upstream wasmparser refactoring.

For now, though, the intention is to get on the train of wasmparser's
latest main branch to ensure we get bug fixes and such.

As part of this update a few other crates and such were updated. This is
primarily to handle the new encoding of ref.is_null where the type is
not part of the instruction encoding any more.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2020 at 19:50):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2020 at 19:50):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2020 at 19:50):

fitzgen created PR Review Comment:

This is a nice clean up over what we had before.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2020 at 20:13):

alexcrichton updated PR #2013 from update-wasmparser to main:

This commit is intended to update wasmparser to 0.59.0. This primarily
includes bytecodealliance/wasm-tools#40 which is a large update to how
parsing and validation works. The impact on Wasmtime is pretty small at
this time, but over time I'd like to refactor the internals here to lean
more heavily on that upstream wasmparser refactoring.

For now, though, the intention is to get on the train of wasmparser's
latest main branch to ensure we get bug fixes and such.

As part of this update a few other crates and such were updated. This is
primarily to handle the new encoding of ref.is_null where the type is
not part of the instruction encoding any more.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 13 2020 at 21:22):

alexcrichton merged PR #2013.


Last updated: Oct 23 2024 at 20:03 UTC