wasmtime / PR #2005 Make wasmtime_environ::Module seriali... · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #2005 Make wasmtime_environ::Module seriali...

Wasmtime GitHub notifications bot (Jul 09 2020 at 23:02):

yurydelendik opened PR #2005 from serialize-module to main:

As being part of CompilationArtifacts, it will be nice to make Module and ModuleLocal serializable.

Changes:

Defines WasmTime and WasmFuncType in the Cranelift, instead of re-exporting from wasmparser (also removes un-need cases in wasmtime crate)

Adds serde attributes to cranelift_wasm types (that need them)

Adds logic for serializing Module::id and Module::passive_data

Wasmtime GitHub notifications bot (Jul 10 2020 at 18:52):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jul 10 2020 at 18:52):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jul 10 2020 at 18:52):

fitzgen created PR Review Comment:

Not really something for this PR, but I kind of wish we had a wasm-types crate or something that our whole crate graph could depend on, so that we weren't converting back and forth between identical types all the time.

Wasmtime GitHub notifications bot (Jul 10 2020 at 18:52):

fitzgen created PR Review Comment:

Instead of panicking here, let's make this a TryFrom impl instead of a From impl: https://doc.rust-lang.org/nightly/core/convert/trait.TryFrom.html

And then callers can do the unwrap, where they have context to know that the given wasmparser::Type is a valid valtype.

Wasmtime GitHub notifications bot (Jul 10 2020 at 19:47):

yurydelendik updated PR #2005 from serialize-module to main:

As being part of CompilationArtifacts, it will be nice to make Module and ModuleLocal serializable.

Changes:

Defines WasmTime and WasmFuncType in the Cranelift, instead of re-exporting from wasmparser (also removes un-need cases in wasmtime crate)

Adds serde attributes to cranelift_wasm types (that need them)

Adds logic for serializing Module::id and Module::passive_data

Wasmtime GitHub notifications bot (Jul 10 2020 at 20:56):

yurydelendik merged PR #2005.

Last updated: Dec 23 2024 at 13:07 UTC