Stream: git-wasmtime

Topic: wasmtime / PR #1991 Support reference types in `Func::wrap`

Wasmtime GitHub notifications bot (Jul 07 2020 at 18:10):

fitzgen edited PR #1991 from func-wrap-and-ref-types to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 07 2020 at 18:28):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Jul 07 2020 at 20:53):

fitzgen updated PR #1991 from func-wrap-and-ref-types to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 07 2020 at 20:54):

fitzgen requested alexcrichton for a review on PR #1991.

Wasmtime GitHub notifications bot (Jul 07 2020 at 21:08):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Jul 07 2020 at 21:08):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Jul 07 2020 at 21:08):

alexcrichton created PR Review Comment:

Looking again at this, I think this location also needs a check for store compatibility because the $args are arbitrarily entering here from the host and we're passing them off to wasm below.

Wasmtime GitHub notifications bot (Jul 07 2020 at 21:27):

fitzgen updated PR #1991 from func-wrap-and-ref-types to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 07 2020 at 21:28):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jul 07 2020 at 21:28):

fitzgen created PR Review Comment:

good eye -- also nice that compatible_with_store is its own method, rather than a fused operation with into_abi_for_arg, because it is super simple to reuse here.

Wasmtime GitHub notifications bot (Jul 07 2020 at 23:03):

fitzgen merged PR #1991.

Last updated: Nov 22 2024 at 16:03 UTC