Stream: git-wasmtime

Topic: wasmtime / PR #1989 corrrect the files' directory index w...

Wasmtime GitHub notifications bot (Jul 07 2020 at 13:19):

ggreif opened PR #1989 from correct-dir-index to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 07 2020 at 13:34):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Jul 07 2020 at 13:34):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Jul 07 2020 at 13:34):

bjorn3 created PR Review Comment:

        // since we are outputting DWARF-4, perform base change

Wasmtime GitHub notifications bot (Jul 07 2020 at 13:34):

bjorn3 created PR Review Comment:

            let dir_index = file_entry.directory_index() + directory_index_correction;

Wasmtime GitHub notifications bot (Jul 07 2020 at 14:01):

ggreif updated PR #1989 from correct-dir-index to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Last updated: Oct 23 2024 at 20:03 UTC