Stream: git-wasmtime

Topic: wasmtime / PR #1989 Correct the files' directory index wh...

Wasmtime GitHub notifications bot (Jul 07 2020 at 14:03):

ggreif edited PR #1989 from correct-dir-index to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 07 2020 at 14:04):

ggreif edited PR #1989 from correct-dir-index to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Fixes #1988.

Wasmtime GitHub notifications bot (Jul 07 2020 at 14:48):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Jul 07 2020 at 14:48):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Jul 07 2020 at 14:48):

yurydelendik created PR Review Comment:

Based on the comment above, the directory_index_base is a better name.

nit: can you also make the comment as a sentence: capitalize the "S" and add the period?

Wasmtime GitHub notifications bot (Jul 07 2020 at 14:48):

yurydelendik edited PR Review Comment.

Wasmtime GitHub notifications bot (Jul 07 2020 at 15:21):

ggreif submitted PR Review.

Wasmtime GitHub notifications bot (Jul 07 2020 at 15:21):

ggreif created PR Review Comment:

I was hesitant naming it _base, because we have two index bases here. Output has base 1 and input can have base 0 or 1.

Wasmtime GitHub notifications bot (Jul 07 2020 at 15:22):

ggreif submitted PR Review.

Wasmtime GitHub notifications bot (Jul 07 2020 at 15:22):

ggreif created PR Review Comment:

        // Since we are outputting DWARF-4, perform base change.

Wasmtime GitHub notifications bot (Jul 07 2020 at 15:23):

ggreif updated PR #1989 from correct-dir-index to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Fixes #1988.

Wasmtime GitHub notifications bot (Jul 07 2020 at 16:17):

yurydelendik has marked PR #1989 as ready for review.

Wasmtime GitHub notifications bot (Jul 07 2020 at 16:20):

yurydelendik merged PR #1989.

Last updated: Dec 23 2024 at 13:07 UTC