Wasmtime GitHub notifications bot (Jul 06 2020 at 21:20): Wasmtime GitHub notifications bot (Jul 06 2020 at 21:20):peterhuene requested alexcrichton and iximeow for a review on PR #1983.
Wasmtime GitHub notifications bot (Jul 06 2020 at 21:20):peterhuene opened PR #1983 from fix-unwind-info to main:
This PR removes the "set frame pointer" unwind code and frame
pointer information from Windows x64 unwind information.In Windows x64 unwind information, a "frame pointer" is actually the
base address of the static part of the local frame and would be at some
negative offset to RSP upon establishing the frame pointer.Currently Cranelift uses a "traditional" notion of a frame pointer, one
that is the highest address in the local frame (i.e. pointing at the
previous frame pointer on the stack).Windows x64 unwind doesn't describe such frame pointers and only needs
one described if the frame contains a dynamic stack allocation.Fixes #1967.
Wasmtime GitHub notifications bot (Jul 06 2020 at 21:20):peterhuene requested alexcrichton and iximeow for a review on PR #1983.
Wasmtime GitHub notifications bot (Jul 06 2020 at 21:23):peterhuene updated PR #1983 from fix-unwind-info to main:
This PR removes the "set frame pointer" unwind code and frame
pointer information from Windows x64 unwind information.In Windows x64 unwind information, a "frame pointer" is actually the
base address of the static part of the local frame and would be at some
negative offset to RSP upon establishing the frame pointer.Currently Cranelift uses a "traditional" notion of a frame pointer, one
that is the highest address in the local frame (i.e. pointing at the
previous frame pointer on the stack).Windows x64 unwind doesn't describe such frame pointers and only needs
one described if the frame contains a dynamic stack allocation.Fixes #1967.
Wasmtime GitHub notifications bot (Jul 06 2020 at 21:42):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jul 06 2020 at 23:47):iximeow submitted PR Review.
Wasmtime GitHub notifications bot (Jul 07 2020 at 01:40):iximeow submitted PR Review.
Wasmtime GitHub notifications bot (Jul 07 2020 at 01:54):peterhuene updated PR #1983 from fix-unwind-info to main:
This PR removes the "set frame pointer" unwind code and frame
pointer information from Windows x64 unwind information.In Windows x64 unwind information, a "frame pointer" is actually the
base address of the static part of the local frame and would be at some
negative offset to RSP upon establishing the frame pointer.Currently Cranelift uses a "traditional" notion of a frame pointer, one
that is the highest address in the local frame (i.e. pointing at the
previous frame pointer on the stack).Windows x64 unwind doesn't describe such frame pointers and only needs
one described if the frame contains a dynamic stack allocation.Fixes #1967.
Wasmtime GitHub notifications bot (Jul 07 2020 at 02:03):peterhuene updated PR #1983 from fix-unwind-info to main:
This PR removes the "set frame pointer" unwind code and frame
pointer information from Windows x64 unwind information.In Windows x64 unwind information, a "frame pointer" is actually the
base address of the static part of the local frame and would be at some
negative offset to RSP upon establishing the frame pointer.Currently Cranelift uses a "traditional" notion of a frame pointer, one
that is the highest address in the local frame (i.e. pointing at the
previous frame pointer on the stack).Windows x64 unwind doesn't describe such frame pointers and only needs
one described if the frame contains a dynamic stack allocation.Fixes #1967.
Wasmtime GitHub notifications bot (Jul 07 2020 at 05:26):peterhuene merged PR #1983.
Last updated: Dec 23 2024 at 13:07 UTC