Stream: git-wasmtime

Topic: wasmtime / PR #1975 peepmatic: add reminder by a power of...

Wasmtime GitHub notifications bot (Jul 03 2020 at 07:16):

MaxGraey edited PR #1975 from more-peephole-opts to main:

This PR add optimization rule for peepmatic DSL which simplify reminder with pow of two constants similar to udiv rule.

TODO

• [ ] fuzzing

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Wasmtime GitHub notifications bot (Jul 03 2020 at 08:01):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Jul 03 2020 at 08:01):

bjorn3 created PR Review Comment:

nit: missing trailing newline

Wasmtime GitHub notifications bot (Jul 03 2020 at 08:01):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Jul 03 2020 at 08:03):

MaxGraey updated PR #1975 from more-peephole-opts to main:

This PR add optimization rule for peepmatic DSL which simplify reminder with pow of two constants similar to udiv rule.

TODO

• [ ] fuzzing

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Wasmtime GitHub notifications bot (Jul 03 2020 at 08:03):

MaxGraey submitted PR Review.

Wasmtime GitHub notifications bot (Jul 03 2020 at 08:03):

MaxGraey created PR Review Comment:

fixed

Wasmtime GitHub notifications bot (Jul 03 2020 at 08:06):

MaxGraey updated PR #1975 from more-peephole-opts to main:

This PR add optimization rule for peepmatic DSL which simplify reminder with pow of two constants similar to udiv rule.

TODO

• [ ] fuzzing

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Wasmtime GitHub notifications bot (Jul 03 2020 at 08:46):

MaxGraey updated PR #1975 from more-peephole-opts to main:

This PR add optimization rule for peepmatic DSL which simplify reminder with pow of two constants similar to udiv rule.

TODO

• [ ] fuzzing

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Wasmtime GitHub notifications bot (Jul 03 2020 at 08:50):

MaxGraey edited PR #1975 from more-peephole-opts to main:

This PR add optimization rule for peepmatic DSL which simplify reminder with pow of two constants similar to udiv rule.
Test cases already exists.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [x] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Wasmtime GitHub notifications bot (Jul 03 2020 at 08:50):

MaxGraey has marked PR #1975 as ready for review.

Wasmtime GitHub notifications bot (Jul 03 2020 at 18:44):

MaxGraey edited PR #1975 from more-peephole-opts to main:

This PR add optimization rule for peepmatic DSL which simplify reminder with pow of two constants similar to udiv rule.
Test cases already exists.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [x] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Wasmtime GitHub notifications bot (Jul 03 2020 at 18:45):

MaxGraey updated PR #1975 from more-peephole-opts to main:

This PR add optimization rule for peepmatic DSL which simplify reminder with pow of two constants similar to udiv rule.
Test cases already exists.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [x] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Wasmtime GitHub notifications bot (Jul 06 2020 at 22:16):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jul 06 2020 at 22:16):

fitzgen created PR Review Comment:

Can you keep these in alphabetical order? So Isub would go after Imul here.

Wasmtime GitHub notifications bot (Jul 06 2020 at 22:16):

fitzgen created PR Review Comment:

As written, this isn't correct. For example:

2 % 4 = 2
2 & (1 - 4) = 0

Looks like the operands are mixed up here. They should be:

    (band_imm $(isub $C 1) $x))

(If you were confused by irsub_imm, its operands are reversed just because peepmatic requires all immediates to come before arguments right now, but we plan to lift that restriction eventually).

Wasmtime GitHub notifications bot (Jul 06 2020 at 22:16):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jul 06 2020 at 22:42):

MaxGraey submitted PR Review.

Wasmtime GitHub notifications bot (Jul 06 2020 at 22:42):

MaxGraey created PR Review Comment:

I see, thanks! Will fix this later

Wasmtime GitHub notifications bot (Jul 06 2020 at 22:55):

MaxGraey updated PR #1975 from more-peephole-opts to main:

This PR add optimization rule for peepmatic DSL which simplify reminder with pow of two constants similar to udiv rule.
Test cases already exists.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [x] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Wasmtime GitHub notifications bot (Jul 06 2020 at 23:16):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jul 06 2020 at 23:32):

fitzgen merged PR #1975.

Last updated: Dec 23 2024 at 13:07 UTC