Wasmtime GitHub notifications bot (Jul 02 2020 at 17:45): Wasmtime GitHub notifications bot (Jul 02 2020 at 17:45):fitzgen opened PR #1969 from externref-globals to main:
We use libcalls to implement these -- unlike
table.{get,set}, for which we
create inline JIT fast paths -- because no known toolchain actually uses
externref globals.Part of #929
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 02 2020 at 17:45):fitzgen requested alexcrichton for a review on PR #1969.
Wasmtime GitHub notifications bot (Jul 02 2020 at 17:55):fitzgen updated PR #1969 from externref-globals to main:
We use libcalls to implement these -- unlike
table.{get,set}, for which we
create inline JIT fast paths -- because no known toolchain actually uses
externref globals.Part of #929
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 02 2020 at 18:06):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jul 02 2020 at 18:06):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jul 02 2020 at 18:06):alexcrichton created PR Review Comment:
Could this also assert that
gc_count.get()is 0 before the call?
Wasmtime GitHub notifications bot (Jul 02 2020 at 18:06):alexcrichton created PR Review Comment:
Like above, could this assert that it's not touched before the call?
Wasmtime GitHub notifications bot (Jul 02 2020 at 19:58):fitzgen updated PR #1969 from externref-globals to main:
We use libcalls to implement these -- unlike
table.{get,set}, for which we
create inline JIT fast paths -- because no known toolchain actually uses
externref globals.Part of #929
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 02 2020 at 20:41):fitzgen requested alexcrichton for a review on PR #1969.
Wasmtime GitHub notifications bot (Jul 02 2020 at 21:04):alexcrichton merged PR #1969.
Last updated: Nov 22 2024 at 17:03 UTC