Stream: git-wasmtime

Topic: wasmtime / PR #1965 Use smallvec for avoid allocations in...


view this post on Zulip Wasmtime GitHub notifications bot (Jul 02 2020 at 11:56):

pepyakin opened PR #1965 from ser-host-func-opt to main:

We, in paritytech, had to momentarily fork wasmtime due to lack of support of sharing Modules between threads. Now, with the recent changes landed it is possible for us to return to the upstream!

One of the changes we had in our fork is similar to the presented here. Namely, we noticed a performance increase for our workloads if we avoid allocations for a common case if the number of arguments doesn't exceed some threshold.

In our fork it wasn't using smallvec, but I don't think it's worth the hassle avoiding it since smallvec is already used by cranelift.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 02 2020 at 11:56):

pepyakin requested alexcrichton for a review on PR #1965.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 02 2020 at 16:24):

alexcrichton merged PR #1965.


Last updated: Nov 22 2024 at 17:03 UTC