Wasmtime GitHub notifications bot (Jul 01 2020 at 00:42): Wasmtime GitHub notifications bot (Jul 01 2020 at 00:42):cfallin opened PR #1954 from b1649432 to main:
The failure to mask the amount triggered a panic due to a subtraction
overflow check; see
https://bugzilla.mozilla.org/show_bug.cgi?id=1649432. Attempting to
shift by an out-of-range amount should be defined to shift by an amount
mod the operand size (i.e., masked to 5 bits for 32-bit shifts, or 6
bits for 64-bit shifts).<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 01 2020 at 00:42):cfallin requested bnjbvr and julian-seward1 for a review on PR #1954.
Wasmtime GitHub notifications bot (Jul 01 2020 at 00:42):cfallin requested bnjbvr and julian-seward1 for a review on PR #1954.
Wasmtime GitHub notifications bot (Jul 01 2020 at 05:19):julian-seward1 submitted PR Review.
Wasmtime GitHub notifications bot (Jul 01 2020 at 10:19):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Jul 01 2020 at 10:19):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Jul 01 2020 at 10:19):bnjbvr created PR Review Comment:
Can you add a CLIF test instead?
Wasmtime GitHub notifications bot (Jul 01 2020 at 15:58):cfallin updated PR #1954 from b1649432 to main:
The failure to mask the amount triggered a panic due to a subtraction
overflow check; see
https://bugzilla.mozilla.org/show_bug.cgi?id=1649432. Attempting to
shift by an out-of-range amount should be defined to shift by an amount
mod the operand size (i.e., masked to 5 bits for 32-bit shifts, or 6
bits for 64-bit shifts).<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 01 2020 at 16:00):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Jul 01 2020 at 16:00):cfallin created PR Review Comment:
Done!
Wasmtime GitHub notifications bot (Jul 01 2020 at 16:33):cfallin merged PR #1954.
Last updated: Dec 23 2024 at 12:05 UTC