Stream: git-wasmtime

Topic: wasmtime / PR #1951 Rename `OFlag`/`AtFlag` to `OFlags`/`...

Wasmtime GitHub notifications bot (Jun 30 2020 at 22:36):

sunfishcode opened PR #1951 from sunfishcode/yanix-misc to main:

This makes them consistent with PollFlags and common usage of
bitflags types in Rust code in general.

POSIX does tend to use names like oflag and flag, so this is in mild
disagreement with POSIX style, however I find this particular aspects of
POSIX confusing because these values hold multiple flags.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 30 2020 at 22:36):

sunfishcode requested kubkon for a review on PR #1951.

Wasmtime GitHub notifications bot (Jun 30 2020 at 23:16):

sunfishcode updated PR #1951 from sunfishcode/yanix-misc to main:

This makes them consistent with PollFlags and common usage of
bitflags types in Rust code in general.

POSIX does tend to use names like oflag and flag, so this is in mild
disagreement with POSIX style, however I find this particular aspects of
POSIX confusing because these values hold multiple flags.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 01 2020 at 01:40):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Jul 01 2020 at 18:37):

kubkon submitted PR Review.

Wasmtime GitHub notifications bot (Jul 01 2020 at 18:53):

kubkon merged PR #1951.

Last updated: Dec 23 2024 at 12:05 UTC