Stream: git-wasmtime

Topic: wasmtime / PR #1950 Use AsRef<Path> instead of AsRef<OsSt...

Wasmtime GitHub notifications bot (Jun 30 2020 at 18:39):

sunfishcode opened PR #1950 from sunfishcode/yanix-path to main:

AsRef<Path> makes these more consistent with std interfaces, making
them easier to use outside of wasi-common.

Also, refactor the conversion to CString into a helper function.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 30 2020 at 19:12):

sunfishcode requested kubkon for a review on PR #1950.

Wasmtime GitHub notifications bot (Jun 30 2020 at 19:34):

sunfishcode updated PR #1950 from sunfishcode/yanix-path to main:

AsRef<Path> makes these more consistent with std interfaces, making
them easier to use outside of wasi-common.

Also, refactor the conversion to CString into a helper function.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 30 2020 at 19:54):

iximeow submitted PR Review.

Wasmtime GitHub notifications bot (Jun 30 2020 at 20:06):

sunfishcode updated PR #1950 from sunfishcode/yanix-path to main:

AsRef<Path> makes these more consistent with std interfaces, making
them easier to use outside of wasi-common.

Also, refactor the conversion to CString into a helper function.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 01 2020 at 18:34):

kubkon submitted PR Review.

Wasmtime GitHub notifications bot (Jul 01 2020 at 18:34):

kubkon submitted PR Review.

Wasmtime GitHub notifications bot (Jul 01 2020 at 18:34):

kubkon created PR Review Comment:

We already pull in std::io::{Error, Result} into scope in this module, so we might as well use it here. Also, while we already do that, I guess we could pull in std::path::Path and std::ffi::CString. It's a minor stylistic nit, so feel free to ignore!

Wasmtime GitHub notifications bot (Jul 01 2020 at 18:34):

kubkon created PR Review Comment:

Hmm, shouldn't these two be the other way around? Weirdly enough, there's a mismatch between linux and other hosts in the way this has been formatted in this PR.

Wasmtime GitHub notifications bot (Jul 20 2020 at 15:31):

sunfishcode updated PR #1950 from sunfishcode/yanix-path to main:

AsRef<Path> makes these more consistent with std interfaces, making
them easier to use outside of wasi-common.

Also, refactor the conversion to CString into a helper function.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jul 20 2020 at 15:32):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Jul 20 2020 at 15:32):

sunfishcode created PR Review Comment:

Fixed.

Wasmtime GitHub notifications bot (Jul 20 2020 at 15:32):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Jul 20 2020 at 15:32):

sunfishcode created PR Review Comment:

Fixed.

Wasmtime GitHub notifications bot (Jul 20 2020 at 17:02):

sunfishcode merged PR #1950.

Last updated: Nov 22 2024 at 16:03 UTC