sunfishcode opened PR #1950 from sunfishcode/yanix-path
to main
:
AsRef<Path>
makes these more consistent withstd
interfaces, making
them easier to use outside of wasi-common.Also, refactor the conversion to
CString
into a helper function.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
sunfishcode requested kubkon for a review on PR #1950.
sunfishcode updated PR #1950 from sunfishcode/yanix-path
to main
:
AsRef<Path>
makes these more consistent withstd
interfaces, making
them easier to use outside of wasi-common.Also, refactor the conversion to
CString
into a helper function.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
iximeow submitted PR Review.
sunfishcode updated PR #1950 from sunfishcode/yanix-path
to main
:
AsRef<Path>
makes these more consistent withstd
interfaces, making
them easier to use outside of wasi-common.Also, refactor the conversion to
CString
into a helper function.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
kubkon submitted PR Review.
kubkon submitted PR Review.
kubkon created PR Review Comment:
We already pull in
std::io::{Error, Result}
into scope in this module, so we might as well use it here. Also, while we already do that, I guess we could pull instd::path::Path
andstd::ffi::CString
. It's a minor stylistic nit, so feel free to ignore!
kubkon created PR Review Comment:
Hmm, shouldn't these two be the other way around? Weirdly enough, there's a mismatch between
linux
and other hosts in the way this has been formatted in this PR.
sunfishcode updated PR #1950 from sunfishcode/yanix-path
to main
:
AsRef<Path>
makes these more consistent withstd
interfaces, making
them easier to use outside of wasi-common.Also, refactor the conversion to
CString
into a helper function.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
sunfishcode submitted PR Review.
sunfishcode created PR Review Comment:
Fixed.
sunfishcode submitted PR Review.
sunfishcode created PR Review Comment:
Fixed.
sunfishcode merged PR #1950.
Last updated: Dec 23 2024 at 13:07 UTC