Stream: git-wasmtime

Topic: wasmtime / PR #1942 Upgrade wasmparser to 0.58.0

Wasmtime GitHub notifications bot (Jun 29 2020 at 23:23):

abrown opened PR #1942 from update-wasmparser to main:

In order to get access to the newest SIMD instructions, I upgraded wasmparser to 0.58.0.

There are API changes in wasmparser that need to be resolved before we can merge this. I marked these with unimplemented!() // TODO in various places so that at least we could get this to compile. @yurydelendik, @alexcrichton (I think some of this has to do with module linking and I have seen you discuss that before): could you take a look through these and give me your thoughts on how to implement (or temporarily avoid implementing) these unimplemented! sections?

Wasmtime GitHub notifications bot (Jun 29 2020 at 23:23):

abrown requested alexcrichton for a review on PR #1942.

Wasmtime GitHub notifications bot (Jun 29 2020 at 23:23):

abrown requested alexcrichton and yurydelendik for a review on PR #1942.

Wasmtime GitHub notifications bot (Jun 29 2020 at 23:25):

abrown updated PR #1942 from update-wasmparser to main:

In order to get access to the newest SIMD instructions, I upgraded wasmparser to 0.58.0.

There are API changes in wasmparser that need to be resolved before we can merge this. I marked these with unimplemented!() // TODO in various places so that at least we could get this to compile. @yurydelendik, @alexcrichton (I think some of this has to do with module linking and I have seen you discuss that before): could you take a look through these and give me your thoughts on how to implement (or temporarily avoid implementing) these unimplemented! sections?

Wasmtime GitHub notifications bot (Jun 30 2020 at 15:45):

abrown updated PR #1942 from update-wasmparser to main:

In order to get access to the newest SIMD instructions, I upgraded wasmparser to 0.58.0.

There are API changes in wasmparser that need to be resolved before we can merge this. I marked these with unimplemented!() // TODO in various places so that at least we could get this to compile. @yurydelendik, @alexcrichton (I think some of this has to do with module linking and I have seen you discuss that before): could you take a look through these and give me your thoughts on how to implement (or temporarily avoid implementing) these unimplemented! sections?

Wasmtime GitHub notifications bot (Jun 30 2020 at 16:06):

abrown has marked PR #1942 as ready for review.

Wasmtime GitHub notifications bot (Jun 30 2020 at 16:08):

alexcrichton merged PR #1942.

Last updated: Oct 23 2024 at 20:03 UTC