Stream: git-wasmtime

Topic: wasmtime / PR #1939 Fix Switch for 128bit integers

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2020 at 19:22):

bjorn3 opened PR #1939 from 128bit_switch to main:

Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/757
Required by https://github.com/bjorn3/rustc_codegen_cranelift/issues/743

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2020 at 19:24):

bjorn3 updated PR #1939 from 128bit_switch to main:

Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/757
Required by https://github.com/bjorn3/rustc_codegen_cranelift/issues/743

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 10:33):

tschneidereit requested cfallin, bnjbvr and julian-seward1 for a review on PR #1939.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 10:33):

tschneidereit requested cfallin, bnjbvr and julian-seward1 for a review on PR #1939.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 10:33):

tschneidereit requested cfallin, bnjbvr and julian-seward1 for a review on PR #1939.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 15:02):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 15:02):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 15:02):

cfallin created PR Review Comment:

Can we just assert that the values are <= i64::MAX (or use i64::try_from below) instead? It seems fine to me to build on a 128-bit system and generate 64-bit-sized IR as long as the statically-known values are in range (unless I'm missing some other issue!).

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 15:02):

cfallin created PR Review Comment:

This sequence happens four times -- perhaps extract it into a helper (compare_to_u128 or similar)?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 15:56):

bjorn3 updated PR #1939 from 128bit_switch to main:

Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/757
Required by https://github.com/bjorn3/rustc_codegen_cranelift/issues/743

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 15:57):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 15:57):

cfallin created PR Review Comment:

Sorry to be picky here -- can we pass in an IntCC condition and then combine icmp_imm_u128_{eq,uge}?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 15:58):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 15:58):

bjorn3 created PR Review Comment:

Already realized that :)

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 15:58):

bjorn3 updated PR #1939 from 128bit_switch to main:

Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/757
Required by https://github.com/bjorn3/rustc_codegen_cranelift/issues/743

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 15:59):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 15:59):

bjorn3 created PR Review Comment:

Changed this to assert that blocks.len() fits in an u64.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 16:00):

bjorn3 updated PR #1939 from 128bit_switch to main:

Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/757
Required by https://github.com/bjorn3/rustc_codegen_cranelift/issues/743

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 16:03):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 16:08):

bjorn3 updated PR #1939 from 128bit_switch to main:

Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/757
Required by https://github.com/bjorn3/rustc_codegen_cranelift/issues/743

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2020 at 18:16):

cfallin merged PR #1939.

Last updated: Nov 22 2024 at 17:03 UTC