Wasmtime GitHub notifications bot (Jun 29 2020 at 18:58): Wasmtime GitHub notifications bot (Jun 29 2020 at 18:58):pchickey requested alexcrichton for a review on PR #1938.
Wasmtime GitHub notifications bot (Jun 29 2020 at 18:58):pchickey opened PR #1938 from pch/factor_borrowchecker_out_of_wiggle to main:
The BorrowChecker methods get inlined as part of the GuestMemory trait.
The BorrowChecker implementation moves out to the engines. Unfortunately
this does mean having a copy intest-helpersalong with another in
wasmtime-wiggle. Thewasmtime-wigglecopy will move intowasmtime
itself in a subsequent PR.https://github.com/bytecodealliance/wasmtime/issues/1917
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 29 2020 at 21:18):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jun 29 2020 at 21:18):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jun 29 2020 at 21:18):alexcrichton created PR Review Comment:
Technically this can probably be safe now since the unsafety is now in the
unsafe impl GuestMemory for ...
Wasmtime GitHub notifications bot (Jun 30 2020 at 17:10):pchickey updated PR #1938 from pch/factor_borrowchecker_out_of_wiggle to main:
The BorrowChecker methods get inlined as part of the GuestMemory trait.
The BorrowChecker implementation moves out to the engines. Unfortunately
this does mean having a copy intest-helpersalong with another in
wasmtime-wiggle. Thewasmtime-wigglecopy will move intowasmtime
itself in a subsequent PR.https://github.com/bytecodealliance/wasmtime/issues/1917
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 30 2020 at 17:10):pchickey submitted PR Review.
Wasmtime GitHub notifications bot (Jun 30 2020 at 17:10):pchickey created PR Review Comment:
Thanks! Fixed in 5f5d7cb, will merge once CI passes
Wasmtime GitHub notifications bot (Jun 30 2020 at 18:25):pchickey updated PR #1938 from pch/factor_borrowchecker_out_of_wiggle to main:
The BorrowChecker methods get inlined as part of the GuestMemory trait.
The BorrowChecker implementation moves out to the engines. Unfortunately
this does mean having a copy intest-helpersalong with another in
wasmtime-wiggle. Thewasmtime-wigglecopy will move intowasmtime
itself in a subsequent PR.https://github.com/bytecodealliance/wasmtime/issues/1917
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 30 2020 at 20:08):pchickey merged PR #1938.
Last updated: Oct 23 2024 at 20:03 UTC