pchickey requested alexcrichton for a review on PR #1938.
pchickey opened PR #1938 from pch/factor_borrowchecker_out_of_wiggle
to main
:
The BorrowChecker methods get inlined as part of the GuestMemory trait.
The BorrowChecker implementation moves out to the engines. Unfortunately
this does mean having a copy intest-helpers
along with another in
wasmtime-wiggle
. Thewasmtime-wiggle
copy will move intowasmtime
itself in a subsequent PR.https://github.com/bytecodealliance/wasmtime/issues/1917
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
alexcrichton submitted PR Review.
alexcrichton submitted PR Review.
alexcrichton created PR Review Comment:
Technically this can probably be safe now since the unsafety is now in the
unsafe impl GuestMemory for ...
pchickey updated PR #1938 from pch/factor_borrowchecker_out_of_wiggle
to main
:
The BorrowChecker methods get inlined as part of the GuestMemory trait.
The BorrowChecker implementation moves out to the engines. Unfortunately
this does mean having a copy intest-helpers
along with another in
wasmtime-wiggle
. Thewasmtime-wiggle
copy will move intowasmtime
itself in a subsequent PR.https://github.com/bytecodealliance/wasmtime/issues/1917
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey submitted PR Review.
pchickey created PR Review Comment:
Thanks! Fixed in 5f5d7cb, will merge once CI passes
pchickey updated PR #1938 from pch/factor_borrowchecker_out_of_wiggle
to main
:
The BorrowChecker methods get inlined as part of the GuestMemory trait.
The BorrowChecker implementation moves out to the engines. Unfortunately
this does mean having a copy intest-helpers
along with another in
wasmtime-wiggle
. Thewasmtime-wiggle
copy will move intowasmtime
itself in a subsequent PR.https://github.com/bytecodealliance/wasmtime/issues/1917
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey merged PR #1938.
Last updated: Dec 23 2024 at 13:07 UTC