Stream: git-wasmtime

Topic: wasmtime / PR #1929 wasmtime-wiggle: change stray `log` e...

Wasmtime GitHub notifications bot (Jun 26 2020 at 17:18):

pchickey opened PR #1929 from pch/stray_log_in_wasmtime_wiggle to main:

Wiggle has bought into the tracing ecosystem, which can target either the log or tracing. One stray log::warn! survived the wig -> wasmtime-wiggle transformation in #1910, which means consuming crates need a dep on log. This PR resolves that issue by using the wasmtime-wiggle re-export of tracing, so no additional deps are required.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 26 2020 at 17:30):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Jun 26 2020 at 17:54):

pchickey merged PR #1929.

Last updated: Oct 23 2024 at 20:03 UTC