Wasmtime GitHub notifications bot (Jun 26 2020 at 14:52): Wasmtime GitHub notifications bot (Jun 26 2020 at 14:52):AlexEne opened PR #1927 from main to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[X] This has been discussed in issue #..., or if not, please tell us why
here.[X] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [X] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->This PR changes the
linker.get_default()deafult return value. It removes the return of a no-op function as this is rarely what users of the method would want.This has been briefly discussed in the zulip bytecode alliance channel.
I do not know how to add test cases to this, it seems that there were no tests around it, but I'm happy to add some if anyone could guide me on where to put them.
I am unsure who the right reviewer for this is.
Wasmtime GitHub notifications bot (Jun 26 2020 at 14:52):AlexEne edited PR #1927 from main to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[X] This has been discussed in issue #..., or if not, please tell us why
here.[X] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [X] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->This PR changes the
linker.get_default()deafult return value. It removes the return of a no-op function as this is rarely what users of the method would want. I have replaced it by an error.This has been briefly discussed in the zulip bytecode alliance channel.
I do not know how to add test cases to this, it seems that there were no tests around it, but I'm happy to add some if anyone could guide me on where to put them.
I am unsure who the right reviewer for this is.
Wasmtime GitHub notifications bot (Jun 26 2020 at 14:53):AlexEne edited PR #1927 from main to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[X] This has been discussed in issue #..., or if not, please tell us why
here.[X] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [X] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->This PR changes the
linker.get_default()deafult return value. It removes the return of a no-op function as this is rarely what users of the method would want. I have replaced it with an error that indicates that the module has no default functions to return.This has been briefly discussed in the zulip bytecode alliance channel.
I do not know how to add test cases to this, it seems that there were no tests around it, but I'm happy to add some if anyone could guide me on where to put them.
I am unsure who the right reviewer for this is.
Last updated: Oct 23 2024 at 20:03 UTC