Stream: git-wasmtime

Topic: wasmtime / PR #1927 Do not return a no-op function if def...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 26 2020 at 14:55):

AlexEne edited PR #1927 from main to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

This PR changes the linker.get_default() deafult return value. It removes the return of a no-op function as this is rarely what users of the method would want. I have replaced it with an error that indicates that the module has no default functions to return.

This has been briefly discussed in the zulip bytecode alliance channel.

I do not know how to add test cases to this, it seems that there were no tests around it, but I'm happy to add some if anyone could guide me on where to put them.

I am unsure who the right reviewer for this is.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 26 2020 at 16:32):

alexcrichton requested sunfishcode for a review on PR #1927.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2021 at 10:53):

AlexEne closed without merge PR #1927.


Last updated: Dec 23 2024 at 12:05 UTC