Stream: git-wasmtime

Topic: wasmtime / PR #1926 Remove `HostRef<T>` from the C API

Wasmtime GitHub notifications bot (Jun 26 2020 at 14:07):

alexcrichton opened PR #1926 from remove-hostref to main:

This commit removes HostRef<T> from the C API which only served the
purpose now of converting each type to a wasm_ref_t*. Our
implementation, however, does not guarantee that you'll get the same
wasm_ref_t* for each actual underlying item (e.g. if you put a func in
a table and then get the func as an export and from the table then
same will report false). Additionally the fate of wasm_ref_t*
seems somewhat unclear at this point.

The change here is to make the same and cast functions all abort
saying they're unimplemented. (similar to the host info functions). If
and when we get around to reimplementing these functions we can ensure
they're implemented uniformly and work well for all intended use cases.

Wasmtime GitHub notifications bot (Jun 26 2020 at 19:04):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Jun 26 2020 at 19:34):

alexcrichton merged PR #1926.

Last updated: Nov 22 2024 at 17:03 UTC