Wasmtime GitHub notifications bot (Jun 25 2020 at 17:27): Wasmtime GitHub notifications bot (Jun 25 2020 at 17:27):fitzgen opened PR #1922 from stub-out-host-info-api to master:
Better to be loud that we don't support attaching arbitrary host info to
externrefs than to limp along and pretend we do support it. Supporting it
properly won't reuse any of this code anyways.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 25 2020 at 17:27):fitzgen requested alexcrichton for a review on PR #1922.
Wasmtime GitHub notifications bot (Jun 25 2020 at 18:11):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jun 25 2020 at 18:48):alexcrichton edited PR #1922 from stub-out-host-info-api to main:
Better to be loud that we don't support attaching arbitrary host info to
externrefs than to limp along and pretend we do support it. Supporting it
properly won't reuse any of this code anyways.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 25 2020 at 18:57):fitzgen updated PR #1922 from stub-out-host-info-api to main:
Better to be loud that we don't support attaching arbitrary host info to
externrefs than to limp along and pretend we do support it. Supporting it
properly won't reuse any of this code anyways.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 25 2020 at 20:24):fitzgen updated PR #1922 from stub-out-host-info-api to main:
Better to be loud that we don't support attaching arbitrary host info to
externrefs than to limp along and pretend we do support it. Supporting it
properly won't reuse any of this code anyways.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 25 2020 at 21:01):fitzgen updated PR #1922 from stub-out-host-info-api to main:
Better to be loud that we don't support attaching arbitrary host info to
externrefs than to limp along and pretend we do support it. Supporting it
properly won't reuse any of this code anyways.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 25 2020 at 21:35):fitzgen merged PR #1922.
Last updated: Oct 23 2024 at 20:03 UTC