wasmtime / PR #1915 machinst x64: implement calls and int... · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #1915 machinst x64: implement calls and int...

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:45):

bnjbvr opened PR #1915 from x64-wip to master:

This makes it possible to run a simple recursive fibonacci function in
wasmtime, with the new x64 backend. Plenty of todos implemented as assertions that may and will trigger on larger programs, plenty of paths are still untested, still a lot of missing opcodes lowering and code gen, plenty of optimizations, etc etc.

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:45):

bnjbvr requested cfallin and julian-seward1 for a review on PR #1915.

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:45):

bnjbvr requested cfallin and julian-seward1 for a review on PR #1915.

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:57):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:57):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:57):

bjorn3 created PR Review Comment:

Does space mean size or location?

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:58):

cfallin created PR Review Comment:

Size, in this case (the aarch64 impl is the same (and as an aside, we hope to factor out the commonalities here soon)).

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:58):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:59):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:59):

bjorn3 created PR Review Comment:

    ty.bits()

Wasmtime GitHub notifications bot (Jun 24 2020 at 17:41):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Jun 24 2020 at 17:41):

bjorn3 created PR Review Comment:

Why is it an i64 then? A negative size doesn't make sense.

Wasmtime GitHub notifications bot (Jun 25 2020 at 06:42):

julian-seward1 submitted PR Review.

Wasmtime GitHub notifications bot (Jun 25 2020 at 06:42):

julian-seward1 created PR Review Comment:

pico-nit (smaller even than a nano-nit): These are now sign-extended loads and moves.

Wasmtime GitHub notifications bot (Jun 25 2020 at 06:43):

julian-seward1 submitted PR Review.

Wasmtime GitHub notifications bot (Jun 25 2020 at 06:43):

julian-seward1 created PR Review Comment:

atto-nit: (reg addr), but no imm

Wasmtime GitHub notifications bot (Jun 25 2020 at 06:46):

julian-seward1 submitted PR Review.

Wasmtime GitHub notifications bot (Jun 25 2020 at 06:46):

julian-seward1 created PR Review Comment:

Random comment: if at some point you add tst as an instruction, it has the same "shape" as cmp and so would fit naturally here. (cmp = subtract operands, set flags, throw away result; tst = AND operands; set flags; throw away result).

Wasmtime GitHub notifications bot (Jun 25 2020 at 12:48):

bnjbvr updated PR #1915 from x64-wip to master:

This makes it possible to run a simple recursive fibonacci function in
wasmtime, with the new x64 backend. Plenty of todos implemented as assertions that may and will trigger on larger programs, plenty of paths are still untested, still a lot of missing opcodes lowering and code gen, plenty of optimizations, etc etc.