Stream: git-wasmtime

Topic: wasmtime / PR #1914 Register individual FDEs for musl libc.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 23 2020 at 20:47):

peterhuene opened PR #1914 from fix-musl-unwind to master:

When targeting musl, libunwind is used for the __register_frame
implementation.

Unlike when targeting libgcc which expects an entire frame table, the libunwind
implementation expects a single FDE.

This change ensures Wasmtime registers each individual FDE when targeting musl.

Fixes #1904.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 23 2020 at 20:47):

peterhuene requested yurydelendik for a review on PR #1914.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 23 2020 at 20:51):

peterhuene updated PR #1914 from fix-musl-unwind to master:

When targeting musl, libunwind is used for the __register_frame
implementation.

Unlike when targeting libgcc which expects an entire frame table, the libunwind
implementation expects a single FDE.

This change ensures Wasmtime registers each individual FDE when targeting musl.

Fixes #1904.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 23 2020 at 21:00):

yurydelendik submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 23 2020 at 21:00):

yurydelendik submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 24 2020 at 23:27):

peterhuene updated PR #1914 from fix-musl-unwind to master:

When targeting musl, libunwind is used for the __register_frame
implementation.

Unlike when targeting libgcc which expects an entire frame table, the libunwind
implementation expects a single FDE.

This change ensures Wasmtime registers each individual FDE when targeting musl.

Fixes #1904.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 24 2020 at 23:29):

peterhuene updated PR #1914 from fix-musl-unwind to master:

When targeting musl, libunwind is used for the __register_frame
implementation.

Unlike when targeting libgcc which expects an entire frame table, the libunwind
implementation expects a single FDE.

This change ensures Wasmtime registers each individual FDE when targeting musl.

Fixes #1904.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 00:26):

peterhuene requested yurydelendik for a review on PR #1914.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 14:04):

yurydelendik submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 14:28):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 14:28):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 14:28):

alexcrichton created PR Review Comment:

AFAIK target_env = "" doesn't happen that often on Linux (I'm not sure it ever does), so that may be safe to drop here? Since this seems to be glibc-specific behavior for now it may be best to stick to just target_env = "gnu" anyway too

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 14:28):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 18:40):

peterhuene created PR Review Comment:

Yeah, just going off the docs:

Thus, for example, on many GNU platforms, this value will be empty

I'll drop it for now and merge.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 18:40):

peterhuene submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 18:40):

peterhuene edited PR Review Comment.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 18:43):

peterhuene updated PR #1914 from fix-musl-unwind to master:

When targeting musl, libunwind is used for the __register_frame
implementation.

Unlike when targeting libgcc which expects an entire frame table, the libunwind
implementation expects a single FDE.

This change ensures Wasmtime registers each individual FDE when targeting musl.

Fixes #1904.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 18:48):

alexcrichton edited PR #1914 from fix-musl-unwind to main:

When targeting musl, libunwind is used for the __register_frame
implementation.

Unlike when targeting libgcc which expects an entire frame table, the libunwind
implementation expects a single FDE.

This change ensures Wasmtime registers each individual FDE when targeting musl.

Fixes #1904.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 19:03):

alexcrichton closed without merge PR #1914.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 19:06):

peterhuene reopened PR #1914 from fix-musl-unwind to main:

When targeting musl, libunwind is used for the __register_frame
implementation.

Unlike when targeting libgcc which expects an entire frame table, the libunwind
implementation expects a single FDE.

This change ensures Wasmtime registers each individual FDE when targeting musl.

Fixes #1904.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 25 2020 at 20:02):

peterhuene merged PR #1914.

Last updated: Oct 23 2024 at 20:03 UTC