Wasmtime GitHub notifications bot (Jun 22 2020 at 23:55): Wasmtime GitHub notifications bot (Jun 22 2020 at 23:55):siyopao opened PR #1909 from guestptr-conversion to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->As requested in #1888, adds a method to convert a
GuestPtr<[u8]>to aGuestPtr<str>without first validating that the[u8]consists of utf-8 codepoints. The conversion in the other direction already exists asas_bytes.Although unrelated to this PR, while I was in there I found a couple of small typos in the docs so I fixed them.
Resolves #1888.
Wasmtime GitHub notifications bot (Jun 23 2020 at 16:52):kubkon submitted PR Review.
Wasmtime GitHub notifications bot (Jun 24 2020 at 00:12):siyopao updated PR #1909 from guestptr-conversion to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->As requested in #1888, adds a method to convert a
GuestPtr<[u8]>to aGuestPtr<str>without first validating that the[u8]consists of utf-8 codepoints. The conversion in the other direction already exists asas_bytes.Although unrelated to this PR, while I was in there I found a couple of small typos in the docs so I fixed them.
Resolves #1888.
Wasmtime GitHub notifications bot (Jun 24 2020 at 04:07):pchickey submitted PR Review.
Wasmtime GitHub notifications bot (Jun 24 2020 at 04:07):pchickey submitted PR Review.
Wasmtime GitHub notifications bot (Jun 24 2020 at 04:07):pchickey created PR Review Comment:
/// Returns a pointer to the string represented by a `[u8]` without
Wasmtime GitHub notifications bot (Jun 24 2020 at 04:07):pchickey created PR Review Comment:
/// Returns a pointer for the underlying slice of bytes that this
Wasmtime GitHub notifications bot (Jun 24 2020 at 04:08):pchickey updated PR #1909 from guestptr-conversion to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->As requested in #1888, adds a method to convert a
GuestPtr<[u8]>to aGuestPtr<str>without first validating that the[u8]consists of utf-8 codepoints. The conversion in the other direction already exists asas_bytes.Although unrelated to this PR, while I was in there I found a couple of small typos in the docs so I fixed them.
Resolves #1888.
Wasmtime GitHub notifications bot (Jun 24 2020 at 04:08):pchickey updated PR #1909 from guestptr-conversion to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->As requested in #1888, adds a method to convert a
GuestPtr<[u8]>to aGuestPtr<str>without first validating that the[u8]consists of utf-8 codepoints. The conversion in the other direction already exists asas_bytes.Although unrelated to this PR, while I was in there I found a couple of small typos in the docs so I fixed them.
Resolves #1888.
Wasmtime GitHub notifications bot (Jun 24 2020 at 04:08):pchickey merged PR #1909.
Last updated: Oct 23 2024 at 20:03 UTC