Stream: git-wasmtime

Topic: wasmtime / PR #1909 wiggle: GuestPtr<[u8]> => GuestPtr<st...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2020 at 23:55):

siyopao opened PR #1909 from guestptr-conversion to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

As requested in #1888, adds a method to convert a GuestPtr<[u8]> to a GuestPtr<str> without first validating that the [u8] consists of utf-8 codepoints. The conversion in the other direction already exists as as_bytes.

Although unrelated to this PR, while I was in there I found a couple of small typos in the docs so I fixed them.

Resolves #1888.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 23 2020 at 16:52):

kubkon submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 24 2020 at 00:12):

siyopao updated PR #1909 from guestptr-conversion to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

As requested in #1888, adds a method to convert a GuestPtr<[u8]> to a GuestPtr<str> without first validating that the [u8] consists of utf-8 codepoints. The conversion in the other direction already exists as as_bytes.

Although unrelated to this PR, while I was in there I found a couple of small typos in the docs so I fixed them.

Resolves #1888.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 24 2020 at 04:07):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 24 2020 at 04:07):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 24 2020 at 04:07):

pchickey created PR Review Comment:

    /// Returns a pointer to the string represented by a `[u8]` without

view this post on Zulip Wasmtime GitHub notifications bot (Jun 24 2020 at 04:07):

pchickey created PR Review Comment:

    /// Returns a pointer for the underlying slice of bytes that this

view this post on Zulip Wasmtime GitHub notifications bot (Jun 24 2020 at 04:08):

pchickey updated PR #1909 from guestptr-conversion to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

As requested in #1888, adds a method to convert a GuestPtr<[u8]> to a GuestPtr<str> without first validating that the [u8] consists of utf-8 codepoints. The conversion in the other direction already exists as as_bytes.

Although unrelated to this PR, while I was in there I found a couple of small typos in the docs so I fixed them.

Resolves #1888.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 24 2020 at 04:08):

pchickey updated PR #1909 from guestptr-conversion to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

As requested in #1888, adds a method to convert a GuestPtr<[u8]> to a GuestPtr<str> without first validating that the [u8] consists of utf-8 codepoints. The conversion in the other direction already exists as as_bytes.

Although unrelated to this PR, while I was in there I found a couple of small typos in the docs so I fixed them.

Resolves #1888.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 24 2020 at 04:08):

pchickey merged PR #1909.


Last updated: Dec 23 2024 at 12:05 UTC