Wasmtime GitHub notifications bot (Jun 18 2020 at 15:58): Wasmtime GitHub notifications bot (Jun 18 2020 at 15:58):AlexEne opened PR #1899 from master to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has __not__ been discussed in issue #..., or if not, please tell us why
here.
It wasn't discussed as it's a simple build fix due to a redefinition in the header file that wasmtime provides. (wasmtime.h)[X] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[X] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->Fixed a compilation error due to a redefinition of
wasmtime_profiling_strategy_tas an enum as well as int8_t typedef.
I don't know who can review this, but I would be grateful if someone could take a look, as it's a trivial change.
Wasmtime GitHub notifications bot (Jun 18 2020 at 15:59):fitzgen requested peterhuene for a review on PR #1899.
Wasmtime GitHub notifications bot (Jun 18 2020 at 18:19):peterhuene submitted PR Review.
Wasmtime GitHub notifications bot (Jun 18 2020 at 18:48):AlexEne updated PR #1899 from master to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has __not__ been discussed in issue #..., or if not, please tell us why
here.
It wasn't discussed as it's a simple build fix due to a redefinition in the header file that wasmtime provides. (wasmtime.h)[X] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[X] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->Fixed a compilation error due to a redefinition of
wasmtime_profiling_strategy_tas an enum as well as int8_t typedef.
I don't know who can review this, but I would be grateful if someone could take a look, as it's a trivial change.
Wasmtime GitHub notifications bot (Jun 18 2020 at 23:09):AlexEne updated PR #1899 from master to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has __not__ been discussed in issue #..., or if not, please tell us why
here.
It wasn't discussed as it's a simple build fix due to a redefinition in the header file that wasmtime provides. (wasmtime.h)[X] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[X] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->Fixed a compilation error due to a redefinition of
wasmtime_profiling_strategy_tas an enum as well as int8_t typedef.
I don't know who can review this, but I would be grateful if someone could take a look, as it's a trivial change.
Wasmtime GitHub notifications bot (Jun 18 2020 at 23:14):AlexEne updated PR #1899 from master to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has __not__ been discussed in issue #..., or if not, please tell us why
here.
It wasn't discussed as it's a simple build fix due to a redefinition in the header file that wasmtime provides. (wasmtime.h)[X] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[X] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->Fixed a compilation error due to a redefinition of
wasmtime_profiling_strategy_tas an enum as well as int8_t typedef.
I don't know who can review this, but I would be grateful if someone could take a look, as it's a trivial change.
Wasmtime GitHub notifications bot (Jun 18 2020 at 23:21):AlexEne requested peterhuene for a review on PR #1899.
Wasmtime GitHub notifications bot (Jun 19 2020 at 05:59):peterhuene submitted PR Review.
Wasmtime GitHub notifications bot (Jun 19 2020 at 05:59):peterhuene merged PR #1899.
Last updated: Nov 22 2024 at 16:03 UTC