AlexEne opened PR #1899 from master
to master
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has __not__ been discussed in issue #..., or if not, please tell us why
here.
It wasn't discussed as it's a simple build fix due to a redefinition in the header file that wasmtime provides. (wasmtime.h
)[X] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[X] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->Fixed a compilation error due to a redefinition of
wasmtime_profiling_strategy_t
as an enum as well as int8_t typedef.
I don't know who can review this, but I would be grateful if someone could take a look, as it's a trivial change.
fitzgen requested peterhuene for a review on PR #1899.
peterhuene submitted PR Review.
AlexEne updated PR #1899 from master
to master
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has __not__ been discussed in issue #..., or if not, please tell us why
here.
It wasn't discussed as it's a simple build fix due to a redefinition in the header file that wasmtime provides. (wasmtime.h
)[X] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[X] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->Fixed a compilation error due to a redefinition of
wasmtime_profiling_strategy_t
as an enum as well as int8_t typedef.
I don't know who can review this, but I would be grateful if someone could take a look, as it's a trivial change.
AlexEne updated PR #1899 from master
to master
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has __not__ been discussed in issue #..., or if not, please tell us why
here.
It wasn't discussed as it's a simple build fix due to a redefinition in the header file that wasmtime provides. (wasmtime.h
)[X] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[X] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->Fixed a compilation error due to a redefinition of
wasmtime_profiling_strategy_t
as an enum as well as int8_t typedef.
I don't know who can review this, but I would be grateful if someone could take a look, as it's a trivial change.
AlexEne updated PR #1899 from master
to master
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has __not__ been discussed in issue #..., or if not, please tell us why
here.
It wasn't discussed as it's a simple build fix due to a redefinition in the header file that wasmtime provides. (wasmtime.h
)[X] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[X] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->Fixed a compilation error due to a redefinition of
wasmtime_profiling_strategy_t
as an enum as well as int8_t typedef.
I don't know who can review this, but I would be grateful if someone could take a look, as it's a trivial change.
AlexEne requested peterhuene for a review on PR #1899.
peterhuene submitted PR Review.
peterhuene merged PR #1899.
Last updated: Dec 23 2024 at 12:05 UTC