thibaultcha opened PR #1897 from c-api/linker-get-one-by-name
to master
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->I'd like to use the new Linker to manage my modules from C, is this a supported use-case for the Linker?
alexcrichton submitted PR Review.
alexcrichton created PR Review Comment:
I think the
unsafe
here can be dropped?
alexcrichton submitted PR Review.
thibaultcha updated PR #1897 from c-api/linker-get-one-by-name
to master
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->I'd like to use the new Linker to manage my modules from C, is this a supported use-case for the Linker?
thibaultcha submitted PR Review.
thibaultcha created PR Review Comment:
Good point! I took the liberty of adding a new commit cleaning up a few other unnecessary
unsafe
qualifiers around the C API as well.
alexcrichton submitted PR Review.
alexcrichton submitted PR Review.
alexcrichton created PR Review Comment:
I think this should be
&wasmtime_linker_t
as well, right?
thibaultcha updated PR #1897 from c-api/linker-get-one-by-name
to master
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->I'd like to use the new Linker to manage my modules from C, is this a supported use-case for the Linker?
thibaultcha submitted PR Review.
thibaultcha created PR Review Comment:
As yes, thanks. Updated along with the
wasmtime_linker_get_default()
API as well.
alexcrichton merged PR #1897.
Last updated: Dec 23 2024 at 13:07 UTC