Wasmtime GitHub notifications bot (Jun 18 2020 at 06:34): Wasmtime GitHub notifications bot (Jun 18 2020 at 06:34):thibaultcha opened PR #1897 from c-api/linker-get-one-by-name to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->I'd like to use the new Linker to manage my modules from C, is this a supported use-case for the Linker?
Wasmtime GitHub notifications bot (Jun 18 2020 at 14:11):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jun 18 2020 at 14:11):alexcrichton created PR Review Comment:
I think the
unsafehere can be dropped?
Wasmtime GitHub notifications bot (Jun 18 2020 at 14:11):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jun 18 2020 at 17:44):thibaultcha updated PR #1897 from c-api/linker-get-one-by-name to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->I'd like to use the new Linker to manage my modules from C, is this a supported use-case for the Linker?
Wasmtime GitHub notifications bot (Jun 18 2020 at 18:12):thibaultcha submitted PR Review.
Wasmtime GitHub notifications bot (Jun 18 2020 at 18:12):thibaultcha created PR Review Comment:
Good point! I took the liberty of adding a new commit cleaning up a few other unnecessary
unsafequalifiers around the C API as well.
Wasmtime GitHub notifications bot (Jun 18 2020 at 19:15):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jun 18 2020 at 19:15):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jun 18 2020 at 19:15):alexcrichton created PR Review Comment:
I think this should be
&wasmtime_linker_tas well, right?
Wasmtime GitHub notifications bot (Jun 18 2020 at 19:22):thibaultcha updated PR #1897 from c-api/linker-get-one-by-name to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->I'd like to use the new Linker to manage my modules from C, is this a supported use-case for the Linker?
Wasmtime GitHub notifications bot (Jun 18 2020 at 19:22):thibaultcha submitted PR Review.
Wasmtime GitHub notifications bot (Jun 18 2020 at 19:22):thibaultcha created PR Review Comment:
As yes, thanks. Updated along with the
wasmtime_linker_get_default()API as well.
Wasmtime GitHub notifications bot (Jun 23 2020 at 19:23):alexcrichton merged PR #1897.
Last updated: Oct 23 2024 at 20:03 UTC