Stream: git-wasmtime

Topic: wasmtime / PR #1892 AArch64: Implement SIMD floating-poin...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2020 at 15:52):

akirilov-arm opened PR #1892 from simd_fp_cmp to master:

This PR implements SIMD floating-point comparisons. The new functionality is tested by the spec::simd::simd_f32x4_cmp and spec::simd::simd_f64x2_cmp tests, which also get enabled.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2020 at 15:53):

akirilov-arm edited PR #1892 from simd_fp_cmp to master:

This PR implements SIMD floating-point comparisons for AArch64. The new functionality is tested by the spec::simd::simd_f32x4_cmp and spec::simd::simd_f64x2_cmp tests, which also get enabled.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2020 at 16:43):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2020 at 16:43):

cfallin created PR Review Comment:

No returns in the middle of the big match -- use the ? operator instead to bubble up the CodegenResult on failure.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2020 at 16:43):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 18 2020 at 10:09):

akirilov-arm updated PR #1892 from simd_fp_cmp to master:

This PR implements SIMD floating-point comparisons for AArch64. The new functionality is tested by the spec::simd::simd_f32x4_cmp and spec::simd::simd_f64x2_cmp tests, which also get enabled.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 18 2020 at 19:17):

cfallin merged PR #1892.

Last updated: Nov 22 2024 at 16:03 UTC