Stream: git-wasmtime

Topic: wasmtime / PR #1869 cranelift: add a new resumable_trapnz...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 11:02):

bnjbvr opened PR #1869 from resumable_trap_nz to master:

This is useful to have to allow resumable_trap to happen in loop
headers, for instance. This is the correct way to implement interrupt
checks in Spidermonkey, which are effectively resumable traps. Previous
implementation was using traps, which is wrong, since traps semantically
can't be resumed after.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 11:02):

bnjbvr requested cfallin for a review on PR #1869.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 15:52):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 17:18):

bnjbvr updated PR #1869 from resumable_trap_nz to master:

This is useful to have to allow resumable_trap to happen in loop
headers, for instance. This is the correct way to implement interrupt
checks in Spidermonkey, which are effectively resumable traps. Previous
implementation was using traps, which is wrong, since traps semantically
can't be resumed after.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 17:22):

bnjbvr updated PR #1869 from resumable_trap_nz to master:

This is useful to have to allow resumable_trap to happen in loop
headers, for instance. This is the correct way to implement interrupt
checks in Spidermonkey, which are effectively resumable traps. Previous
implementation was using traps, which is wrong, since traps semantically
can't be resumed after.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 17:23):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2020 at 09:08):

bnjbvr updated PR #1869 from resumable_trap_nz to master:

This is useful to have to allow resumable_trap to happen in loop
headers, for instance. This is the correct way to implement interrupt
checks in Spidermonkey, which are effectively resumable traps. Previous
implementation was using traps, which is wrong, since traps semantically
can't be resumed after.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2020 at 10:04):

bnjbvr merged PR #1869.

Last updated: Nov 22 2024 at 17:03 UTC