Wasmtime GitHub notifications bot (Jun 11 2020 at 21:20): Wasmtime GitHub notifications bot (Jun 11 2020 at 21:20):cfallin opened PR #1866 from remove-matches to master:
When we vendor Cranelift into Firefox, we need to be able to build with
the Firefox CI setup (unless we carry patches on top of upstream).
Unfortunately, the Firefox CI currently appears to build with a slightly
older version of Rust: I can't work out which version exactly, but one
without stable support formatches!().A recent attempt to version-bump Cranelift failed with build errors at
the two locations in this patch:https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305994046&repo=autoland&lineNumber=24829
I also see a bunch of uses of
matches!()in Peepmatic, but those
crates are not built by Firefox, so we can leave them be for now, I
think.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 11 2020 at 21:20):cfallin requested fitzgen for a review on PR #1866.
Wasmtime GitHub notifications bot (Jun 11 2020 at 21:46):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Jun 11 2020 at 21:54):cfallin updated PR #1866 from remove-matches to master:
When we vendor Cranelift into Firefox, we need to be able to build with
the Firefox CI setup (unless we carry patches on top of upstream).
Unfortunately, the Firefox CI currently appears to build with a slightly
older version of Rust: I can't work out which version exactly, but one
without stable support formatches!().A recent attempt to version-bump Cranelift failed with build errors at
the two locations in this patch:https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305994046&repo=autoland&lineNumber=24829
I also see a bunch of uses of
matches!()in Peepmatic, but those
crates are not built by Firefox, so we can leave them be for now, I
think.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 11 2020 at 22:02):cfallin updated PR #1866 from remove-matches to master:
When we vendor Cranelift into Firefox, we need to be able to build with
the Firefox CI setup (unless we carry patches on top of upstream).
Unfortunately, the Firefox CI currently appears to build with a slightly
older version of Rust: I can't work out which version exactly, but one
without stable support formatches!().A recent attempt to version-bump Cranelift failed with build errors at
the two locations in this patch:https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305994046&repo=autoland&lineNumber=24829
I also see a bunch of uses of
matches!()in Peepmatic, but those
crates are not built by Firefox, so we can leave them be for now, I
think.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 11 2020 at 22:02):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Jun 11 2020 at 22:02):fitzgen created PR Review Comment:
This will probably make the
peepmaticjobs fail, right?In the "checks" CI job, could we do:
rustup install 1.41.0 cargo +1.41.0 check -p cranelift?
That would check just the minimum necessary without affecting the rest of the code base, I think.
Wasmtime GitHub notifications bot (Jun 11 2020 at 22:02):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Jun 11 2020 at 22:04):cfallin created PR Review Comment:
Oh, that's a better idea than running all tests redundantly. Thanks!
Wasmtime GitHub notifications bot (Jun 11 2020 at 22:04):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Jun 11 2020 at 22:06):cfallin updated PR #1866 from remove-matches to master:
When we vendor Cranelift into Firefox, we need to be able to build with
the Firefox CI setup (unless we carry patches on top of upstream).
Unfortunately, the Firefox CI currently appears to build with a slightly
older version of Rust: I can't work out which version exactly, but one
without stable support formatches!().A recent attempt to version-bump Cranelift failed with build errors at
the two locations in this patch:https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305994046&repo=autoland&lineNumber=24829
I also see a bunch of uses of
matches!()in Peepmatic, but those
crates are not built by Firefox, so we can leave them be for now, I
think.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 11 2020 at 22:09):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Jun 11 2020 at 22:09):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Jun 11 2020 at 22:09):fitzgen created PR Review Comment:
# for Firefox.
Wasmtime GitHub notifications bot (Jun 11 2020 at 22:11):cfallin updated PR #1866 from remove-matches to master:
When we vendor Cranelift into Firefox, we need to be able to build with
the Firefox CI setup (unless we carry patches on top of upstream).
Unfortunately, the Firefox CI currently appears to build with a slightly
older version of Rust: I can't work out which version exactly, but one
without stable support formatches!().A recent attempt to version-bump Cranelift failed with build errors at
the two locations in this patch:https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305994046&repo=autoland&lineNumber=24829
I also see a bunch of uses of
matches!()in Peepmatic, but those
crates are not built by Firefox, so we can leave them be for now, I
think.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 11 2020 at 22:11):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Jun 11 2020 at 22:11):cfallin created PR Review Comment:
Done!
Wasmtime GitHub notifications bot (Jun 11 2020 at 23:19):cfallin merged PR #1866.
Last updated: Nov 22 2024 at 17:03 UTC