Stream: git-wasmtime

Topic: wasmtime / PR #1860 Refactor debug library to use object:...

Wasmtime GitHub notifications bot (Jun 10 2020 at 22:01):

yurydelendik opened PR #1860 from refactor-debug-elf to master:

(Partially?) addresses #1856

• Uses structures defined in the object crate notice (we use version 0.18 atm)
• Adds GDB smoke tests
• Removes stray test

Wasmtime GitHub notifications bot (Jun 10 2020 at 22:02):

yurydelendik edited PR #1860 from refactor-debug-elf to master:

(Partially?) addresses #1856

• Uses structures defined in the object crate notice (we use version 0.18 atm)
• Adds GDB smoke tests
• Removes stray test (unrelated)

Wasmtime GitHub notifications bot (Jun 11 2020 at 14:08):

yurydelendik updated PR #1860 from refactor-debug-elf to master:

(Partially?) addresses #1856

• Uses structures defined in the object crate notice (we use version 0.18 atm)
• Adds GDB smoke tests
• Removes stray test (unrelated)

Wasmtime GitHub notifications bot (Jun 11 2020 at 14:34):

yurydelendik updated PR #1860 from refactor-debug-elf to master:

(Partially?) addresses #1856

• Uses structures defined in the object crate notice (we use version 0.18 atm)
• Adds GDB smoke tests
• Removes stray test (unrelated)

Wasmtime GitHub notifications bot (Jun 11 2020 at 15:35):

yurydelendik requested fitzgen for a review on PR #1860.

Wasmtime GitHub notifications bot (Jun 11 2020 at 18:39):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jun 11 2020 at 18:39):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jun 11 2020 at 18:39):

fitzgen created PR Review Comment:

Why #[ignore]?

Wasmtime GitHub notifications bot (Jun 11 2020 at 18:52):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Jun 11 2020 at 18:52):

yurydelendik created PR Review Comment:

It requires GDB to be installed in the contributors environment, so we decide to not run it by default. We do similar for LLDB tests -- it is forced to run on CI.

Wasmtime GitHub notifications bot (Jun 11 2020 at 18:53):

yurydelendik edited PR Review Comment.

Wasmtime GitHub notifications bot (Jun 11 2020 at 18:53):

yurydelendik merged PR #1860.

Last updated: Oct 23 2024 at 20:03 UTC