Stream: git-wasmtime

Topic: wasmtime / PR #1853 Allow setting other Cranelift flags w...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2020 at 12:27):

bnjbvr opened PR #1853 from wasmtime-cranelift-flag to master:

This would be handy to try different Cranelift settings while running on real hardware. My immediate use case is trying a different regalloc on aarch64, but I made something generic that would allow to use other cranelift flags in wasmtime too.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2020 at 12:27):

bnjbvr requested alexcrichton for a review on PR #1853.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2020 at 14:41):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2020 at 14:41):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2020 at 14:41):

alexcrichton created PR Review Comment:

I might recommend using splitn here to avoid needing to worry about this case?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2020 at 14:41):

alexcrichton created PR Review Comment:

We may want to flag this method as unsafe? It seems like it's possible that it would be pretty easy to accidentally break safe invariants through arbitrary flags here.

Additionally could this document that it's not necesarily the most stable method in the world? Basically just say that flags are intended to come and go over time, and stability is primarily through the other Config methods.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2020 at 15:11):

bnjbvr updated PR #1853 from wasmtime-cranelift-flag to master:

This would be handy to try different Cranelift settings while running on real hardware. My immediate use case is trying a different regalloc on aarch64, but I made something generic that would allow to use other cranelift flags in wasmtime too.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2020 at 15:18):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2020 at 15:18):

bjorn3 created PR Review Comment:

The only flags that could be unsafe are libcall_call_conv and enable_safepoints I think. avoid_div_traps could result in an unhandled signal and enable_probestack could result in a panic due to a missing libcall impl.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2020 at 15:50):

bnjbvr merged PR #1853.

Last updated: Nov 22 2024 at 16:03 UTC