yurydelendik opened PR #1848 from to-object
to master
:
Using the "object" library everywhere in wasmtime.
See also deprecating note in https://github.com/bytecodealliance/wasmtime/blob/54694b8d0e7318d7ec79964420af573a6ad5056d/cranelift/faerie/README.md
yurydelendik updated PR #1848 from to-object
to master
:
Using the "object" library everywhere in wasmtime.
See also deprecating note in https://github.com/bytecodealliance/wasmtime/blob/54694b8d0e7318d7ec79964420af573a6ad5056d/cranelift/faerie/README.md
yurydelendik requested fitzgen for a review on PR #1848.
fitzgen submitted PR Review.
fitzgen submitted PR Review.
fitzgen created PR Review Comment:
This function should be renamed now, yeah?
yurydelendik updated PR #1848 from to-object
to master
:
Using the "object" library everywhere in wasmtime.
See also deprecating note in https://github.com/bytecodealliance/wasmtime/blob/54694b8d0e7318d7ec79964420af573a6ad5056d/cranelift/faerie/README.md
yurydelendik updated PR #1848 from to-object
to master
:
Using the "object" library everywhere in wasmtime.
See also deprecating note in https://github.com/bytecodealliance/wasmtime/blob/54694b8d0e7318d7ec79964420af573a6ad5056d/cranelift/faerie/README.md
bjorn3 created PR Review Comment:
object::elf
export type definitions for all important structs used here. You can useobject::pod::from_bytes
andobject::pos::bytes_of
to convert between a slice and these structs. Afrom_bytes_mut
method would be useful for this though. You should be able to create one by adaptingfrom_bytes
.
bjorn3 submitted PR Review.
yurydelendik submitted PR Review.
yurydelendik created PR Review Comment:
Cool, thanks for the info. I thought it might be the case. At this PR, I want preserve as much code is I can -- we are missing the GDB testing, so I can do more confident refactoring. Perhaps follow up.
yurydelendik updated PR #1848 from to-object
to master
:
Using the "object" library everywhere in wasmtime.
See also deprecating note in https://github.com/bytecodealliance/wasmtime/blob/54694b8d0e7318d7ec79964420af573a6ad5056d/cranelift/faerie/README.md
bjorn3 submitted PR Review.
bjorn3 created PR Review Comment:
This may cause only part of the file to be written in certain cases.
yurydelendik updated PR #1848 from to-object
to master
:
Using the "object" library everywhere in wasmtime.
See also deprecating note in https://github.com/bytecodealliance/wasmtime/blob/54694b8d0e7318d7ec79964420af573a6ad5056d/cranelift/faerie/README.md
yurydelendik merged PR #1848.
Last updated: Dec 23 2024 at 12:05 UTC