Stream: git-wasmtime

Topic: wasmtime / PR #1848 Migrating code to object (from faerie)

Wasmtime GitHub notifications bot (Jun 09 2020 at 20:41):

yurydelendik opened PR #1848 from to-object to master:

Using the "object" library everywhere in wasmtime.

See also deprecating note in https://github.com/bytecodealliance/wasmtime/blob/54694b8d0e7318d7ec79964420af573a6ad5056d/cranelift/faerie/README.md

Wasmtime GitHub notifications bot (Jun 09 2020 at 20:58):

yurydelendik updated PR #1848 from to-object to master:

Using the "object" library everywhere in wasmtime.

See also deprecating note in https://github.com/bytecodealliance/wasmtime/blob/54694b8d0e7318d7ec79964420af573a6ad5056d/cranelift/faerie/README.md

Wasmtime GitHub notifications bot (Jun 09 2020 at 20:59):

yurydelendik requested fitzgen for a review on PR #1848.

Wasmtime GitHub notifications bot (Jun 09 2020 at 23:14):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jun 09 2020 at 23:14):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jun 09 2020 at 23:14):

fitzgen created PR Review Comment:

This function should be renamed now, yeah?

Wasmtime GitHub notifications bot (Jun 10 2020 at 13:47):

yurydelendik updated PR #1848 from to-object to master:

Using the "object" library everywhere in wasmtime.

See also deprecating note in https://github.com/bytecodealliance/wasmtime/blob/54694b8d0e7318d7ec79964420af573a6ad5056d/cranelift/faerie/README.md

Wasmtime GitHub notifications bot (Jun 10 2020 at 14:01):

yurydelendik updated PR #1848 from to-object to master:

Using the "object" library everywhere in wasmtime.

See also deprecating note in https://github.com/bytecodealliance/wasmtime/blob/54694b8d0e7318d7ec79964420af573a6ad5056d/cranelift/faerie/README.md

Wasmtime GitHub notifications bot (Jun 10 2020 at 14:08):

bjorn3 created PR Review Comment:

object::elf export type definitions for all important structs used here. You can use object::pod::from_bytes and object::pos::bytes_of to convert between a slice and these structs. A from_bytes_mut method would be useful for this though. You should be able to create one by adapting from_bytes.

Wasmtime GitHub notifications bot (Jun 10 2020 at 14:08):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Jun 10 2020 at 14:15):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Jun 10 2020 at 14:15):

yurydelendik created PR Review Comment:

Cool, thanks for the info. I thought it might be the case. At this PR, I want preserve as much code is I can -- we are missing the GDB testing, so I can do more confident refactoring. Perhaps follow up.

Wasmtime GitHub notifications bot (Jun 10 2020 at 14:26):

yurydelendik updated PR #1848 from to-object to master:

Using the "object" library everywhere in wasmtime.

See also deprecating note in https://github.com/bytecodealliance/wasmtime/blob/54694b8d0e7318d7ec79964420af573a6ad5056d/cranelift/faerie/README.md

Wasmtime GitHub notifications bot (Jun 10 2020 at 14:29):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Jun 10 2020 at 14:29):

bjorn3 created PR Review Comment:

This may cause only part of the file to be written in certain cases.

Wasmtime GitHub notifications bot (Jun 10 2020 at 15:20):

yurydelendik updated PR #1848 from to-object to master:

Using the "object" library everywhere in wasmtime.

See also deprecating note in https://github.com/bytecodealliance/wasmtime/blob/54694b8d0e7318d7ec79964420af573a6ad5056d/cranelift/faerie/README.md

Wasmtime GitHub notifications bot (Jun 10 2020 at 16:27):

yurydelendik merged PR #1848.

Last updated: Oct 23 2024 at 20:03 UTC