Stream: git-wasmtime

Topic: wasmtime / PR #1839 Fix stdin/stdout/stderr not being rep...

Wasmtime GitHub notifications bot (Jun 07 2020 at 01:03):

linouxis9 opened PR #1839 from master to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

OsOther cannot be used for file descriptors representing a file or a directory.
https://github.com/bytecodealliance/wasmtime/blob/4bb58940c74c37bdba8630810645cbd41dd0ff7e/crates/wasi-common/src/sys/unix/osother.rs#L16

As such, an OsFile should instead directly be used.

Before this PR, and since #1561, it was not possible to replace stdin/stdout/stderr with an user-provided File.

Wasmtime GitHub notifications bot (Jun 07 2020 at 01:15):

linouxis9 closed without merge PR #1839.

Last updated: Nov 22 2024 at 16:03 UTC