Stream: git-wasmtime

Topic: wasmtime / PR #1838 Vcode refactor helper data structures...

Wasmtime GitHub notifications bot (Jun 11 2020 at 04:44):

jlb6740 edited PR #1838 from vcode-rm-xmm-r-r-x64-enum-case to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 11 2020 at 04:51):

jlb6740 updated PR #1838 from vcode-rm-xmm-r-r-x64-enum-case to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 11 2020 at 05:11):

jlb6740 updated PR #1838 from vcode-rm-xmm-r-r-x64-enum-case to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 17 2020 at 07:03):

jlb6740 updated PR #1838 from vcode-rm-xmm-r-r-x64-enum-case to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 18 2020 at 07:02):

jlb6740 updated PR #1838 from vcode-rm-xmm-r-r-x64-enum-case to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 22 2020 at 18:46):

jlb6740 updated PR #1838 from vcode-rm-xmm-r-r-x64-enum-case to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 22 2020 at 18:50):

jlb6740 updated PR #1838 from vcode-rm-xmm-r-r-x64-enum-case to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 23 2020 at 07:29):

jlb6740 updated PR #1838 from vcode-rm-xmm-r-r-x64-enum-case to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:40):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:40):

bnjbvr created PR Review Comment:

I would have assumed that the tests could be kept, but using the xmm_mov_rm_r constructor instead of the xmm_r_r, and moving these close to the other xmm_mov_rm_r tests. Can you do this here please? (Unless this is a redundant ask because similar tests existed with the other Inst)

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:40):

bnjbvr created PR Review Comment:

ditto here

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:40):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:40):

bnjbvr created PR Review Comment:

Bad rebase here: I think the previous code can be reused effectively by replacing xmm_r_r with xmm_mov_rm_r and adapting to this function's API. Can you do this here please?

Wasmtime GitHub notifications bot (Jun 24 2020 at 16:40):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Jun 24 2020 at 20:24):

jlb6740 submitted PR Review.

Wasmtime GitHub notifications bot (Jun 24 2020 at 20:24):

jlb6740 created PR Review Comment:

Hi .. yes. I included redundant tests earlier when creating the xmm_mov_rm_r structure: See here: https://github.com/bytecodealliance/wasmtime/blob/f2f770626511c08c632c52e5f868ac13170687be/cranelift/codegen/src/isa/x64/inst/emit_tests.rs#L2400-L2409

Wasmtime GitHub notifications bot (Jun 24 2020 at 20:25):

jlb6740 submitted PR Review.

Wasmtime GitHub notifications bot (Jun 24 2020 at 20:25):

jlb6740 created PR Review Comment:

See above. This test is already included I just modified the registers as suggested by @julian-seward1

Wasmtime GitHub notifications bot (Jun 24 2020 at 20:49):

jlb6740 updated PR #1838 from vcode-rm-xmm-r-r-x64-enum-case to master:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 24 2020 at 22:14):

jlb6740 requested bnjbvr for a review on PR #1838.

Wasmtime GitHub notifications bot (Jun 25 2020 at 12:31):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Jun 25 2020 at 12:31):

bnjbvr merged PR #1838.

Last updated: Dec 23 2024 at 12:05 UTC