Wasmtime GitHub notifications bot (Jun 06 2020 at 07:43): Wasmtime GitHub notifications bot (Jun 06 2020 at 07:43):rich-murphey opened PR #1835 from patch-1 to master:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 06 2020 at 12:35):tschneidereit submitted PR Review.
Wasmtime GitHub notifications bot (Jun 06 2020 at 23:06):rich-murphey updated PR #1835 from patch-1 to master:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 07 2020 at 03:05):rich-murphey updated PR #1835 from patch-1 to master:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 07 2020 at 03:38):rich-murphey updated PR #1835 from patch-1 to master:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 07 2020 at 19:06):rich-murphey updated PR #1835 from patch-1 to master:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 09 2020 at 01:07):rich-murphey updated PR #1835 from patch-1 to master:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 15 2020 at 00:41):rich-murphey updated PR #1835 from patch-1 to master:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 15 2020 at 01:04):rich-murphey updated PR #1835 from patch-1 to master:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 15 2020 at 08:27):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Jun 15 2020 at 08:27):bjorn3 created PR Review Comment:
[Wasm] is an assembly language for a [virtual stack machine][VSM]
Wasmtime GitHub notifications bot (Jun 16 2020 at 00:24):rich-murphey updated PR #1835 from patch-1 to master:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 17 2020 at 00:23):rich-murphey updated PR #1835 from patch-1 to master:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 25 2020 at 18:49):alexcrichton edited PR #1835 from patch-1 to main:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 28 2020 at 05:49):rich-murphey updated PR #1835 from patch-1 to main:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 29 2020 at 23:18):rich-murphey updated PR #1835 from patch-1 to main:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 29 2020 at 23:39):rich-murphey updated PR #1835 from patch-1 to main:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 03 2020 at 16:20):rich-murphey updated PR #1835 from patch-1 to main:
As the first introduction it may be helpful for certain readers, to define the abbreviations, and use familiar concrete terms. Consider a reader who is unfamiliar with WASM and is just beginning to study it, and is asking the question, when would l need this? I feel, adding concrete terms, provides more immediate answers to that kind of question.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jul 05 2020 at 05:03):rich-murphey requested tschneidereit for a review on PR #1835.
Wasmtime GitHub notifications bot (Jul 29 2020 at 12:17):tschneidereit submitted PR Review.
Wasmtime GitHub notifications bot (Jul 29 2020 at 12:17):tschneidereit submitted PR Review.
Wasmtime GitHub notifications bot (Jul 29 2020 at 12:17):tschneidereit created PR Review Comment:
Nit: since this is the name of the CLI tool, it needs to stay lowercase
Wasmtime GitHub notifications bot (Jul 29 2020 at 12:17):tschneidereit created PR Review Comment:
I don't think this is quite right: libc is an abstraction layer that can be implemented in terms of WASI, just as it can be implemented in terms of other system interfaces, such as POSIX.
Wasmtime GitHub notifications bot (Mar 01 2024 at 19:06):alexcrichton closed without merge PR #1835.
Wasmtime GitHub notifications bot (Mar 01 2024 at 19:06):alexcrichton commented on PR #1835:
I'm going through some old PRs and I see that this one has languished for quite awhile. I'm going to close this as quite a lot has changed in the meantime, but PRs are of course always welcome for improvements!
Last updated: Nov 22 2024 at 16:03 UTC