Stream: git-wasmtime

Topic: wasmtime / PR #1833 Wasm translator multi-value bugfix: h...

Wasmtime GitHub notifications bot (Jun 06 2020 at 00:33):

cfallin opened PR #1833 from multi-value-loop to master:

It appears that the CLIF generation for a branch to a loop label did not taken into account the possibility of loop-block parameters. I believe the correct semantics here (at least as far as I understood the spec) are to pop new versions of the loop params off the stack at the point of the branch.

This PR fixes spec/multi-value/block-run.wast in the newer version of spec_testsuite, which we aren't yet using in the wasmtime tree but which SpiderMonkey is. This bug was caught during integration of the multivalue work with SpiderMonkey.

(The loop-params.wast test added in this PR is the one particular failing case from block-run.wast.)

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 06 2020 at 00:33):

cfallin requested bnjbvr for a review on PR #1833.

Wasmtime GitHub notifications bot (Jun 08 2020 at 15:43):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Jun 08 2020 at 19:21):

cfallin merged PR #1833.

Last updated: Nov 22 2024 at 16:03 UTC