Stream: git-wasmtime

Topic: wasmtime / PR #1833 Wasm translator multi-value bugfix: h...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 06 2020 at 00:33):

cfallin opened PR #1833 from multi-value-loop to master:

It appears that the CLIF generation for a branch to a loop label did not taken into account the possibility of loop-block parameters. I believe the correct semantics here (at least as far as I understood the spec) are to pop new versions of the loop params off the stack at the point of the branch.

This PR fixes spec/multi-value/block-run.wast in the newer version of spec_testsuite, which we aren't yet using in the wasmtime tree but which SpiderMonkey is. This bug was caught during integration of the multivalue work with SpiderMonkey.

(The loop-params.wast test added in this PR is the one particular failing case from block-run.wast.)

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 06 2020 at 00:33):

cfallin requested bnjbvr for a review on PR #1833.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 08 2020 at 15:43):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 08 2020 at 19:21):

cfallin merged PR #1833.


Last updated: Dec 23 2024 at 12:05 UTC