Stream: git-wasmtime

Topic: wasmtime / PR #1831 Refactor CompiledModule to separate c...

Wasmtime GitHub notifications bot (Jun 05 2020 at 20:33):

yurydelendik opened PR #1831 from relocs to master:

This is a major refactoring to:

• Uniformly handle relocation data for functions and trampolines
• Store relocations with its code
• Separate debug image generation from DWARF sections creation (and their relocations)
• Cleaner linking

No new functionality added here, mostly moving code around. Though it is a first step to allow serialization of compilation artifacts with ability to instantiate that later.

Wasmtime GitHub notifications bot (Jun 08 2020 at 16:17):

alexcrichton created PR Review Comment:

Is the goal here to largely get rid of the Compilation structure? I used that for a bit as a convenient "here's a package of a whole bunch of stuff" so when a field was added you didn't have to go add a bunch of parameters to a bunch of functions.

Also I think the <'a> here can be removed?

Wasmtime GitHub notifications bot (Jun 08 2020 at 16:17):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Jun 08 2020 at 16:17):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Jun 08 2020 at 16:17):

alexcrichton created PR Review Comment:

I probably wouldn't bother defining this since it's only used for one function.

Wasmtime GitHub notifications bot (Jun 08 2020 at 22:11):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Jun 08 2020 at 22:11):

yurydelendik created PR Review Comment:

yes, the caller "shreds" fields of the Compilation and changes their ownership -- only few are useful here (see LinkContext below). Passing entire Compilation into link_module blocks few compilation operations to be done sooner.

Wasmtime GitHub notifications bot (Jun 09 2020 at 00:03):

yurydelendik updated PR #1831 from relocs to master:

This is a major refactoring to:

• Uniformly handle relocation data for functions and trampolines
• Store relocations with its code
• Separate debug image generation from DWARF sections creation (and their relocations)
• Cleaner linking

No new functionality added here, mostly moving code around. Though it is a first step to allow serialization of compilation artifacts with ability to instantiate that later.

Wasmtime GitHub notifications bot (Jun 09 2020 at 20:09):

alexcrichton merged PR #1831.

Last updated: Dec 23 2024 at 13:07 UTC