Stream: git-wasmtime

Topic: wasmtime / PR #1826 arm64: Implement Icmp for I16X8 and I...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 05 2020 at 10:20):

jgouly opened PR #1826 from cmp-i16-i32 to master:

Copyright (c) 2020, Arm Limited.

Probably best to not merge this until https://github.com/bytecodealliance/wasmtime/pull/1802 is, since I don't want to cause more trouble for Anton.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 05 2020 at 19:03):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 05 2020 at 19:03):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 05 2020 at 19:03):

cfallin created PR Review Comment:

I think the return is the best choice here -- in more recent PRs we've been trying to move toward CodegenErrors rather than panics (partly this is out of a desire to allow clean failure of compilation in embeddings that might care about panics).

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 09:56):

jgouly updated PR #1826 from cmp-i16-i32 to master:

Copyright (c) 2020, Arm Limited.

Probably best to not merge this until https://github.com/bytecodealliance/wasmtime/pull/1802 is, since I don't want to cause more trouble for Anton.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 17:14):

cfallin updated PR #1826 from cmp-i16-i32 to master:

Copyright (c) 2020, Arm Limited.

Probably best to not merge this until https://github.com/bytecodealliance/wasmtime/pull/1802 is, since I don't want to cause more trouble for Anton.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 17:29):

cfallin updated PR #1826 from cmp-i16-i32 to master:

Copyright (c) 2020, Arm Limited.

Probably best to not merge this until https://github.com/bytecodealliance/wasmtime/pull/1802 is, since I don't want to cause more trouble for Anton.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 18:08):

cfallin updated PR #1826 from cmp-i16-i32 to master:

Copyright (c) 2020, Arm Limited.

Probably best to not merge this until https://github.com/bytecodealliance/wasmtime/pull/1802 is, since I don't want to cause more trouble for Anton.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 19:28):

cfallin merged PR #1826.

Last updated: Dec 23 2024 at 12:05 UTC