Wasmtime GitHub notifications bot (Jun 04 2020 at 22:33): Wasmtime GitHub notifications bot (Jun 04 2020 at 22:33):fitzgen opened PR #1824 from test-stack-maps to master:
One of the new tests introduced here is not passing yet, because it looks like Cranelift is generating incorrect stack frames / stack maps, but I'd like to get a second set of eyes on whether this is the expected result or not before I dive into debugging + fixing it.
Also, it would be nice if we could verify that my understanding of how Cranelift's stack maps are supposed to work is correct in the new doc comments.
@eqrion, could you take a look at this please? Thanks!
Wasmtime GitHub notifications bot (Jun 04 2020 at 22:33):fitzgen requested eqrion for a review on PR #1824.
Wasmtime GitHub notifications bot (Jun 04 2020 at 22:34):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Jun 04 2020 at 22:34):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Jun 04 2020 at 22:34):fitzgen created PR Review Comment:
This is the function that looks like it has an incorrect stack frame and stack map. See the comment and table for explanation.
Wasmtime GitHub notifications bot (Jun 08 2020 at 18:04):eqrion submitted PR Review.
Wasmtime GitHub notifications bot (Jun 08 2020 at 22:06):fitzgen updated PR #1824 from test-stack-maps to master:
One of the new tests introduced here is not passing yet, because it looks like Cranelift is generating incorrect stack frames / stack maps, but I'd like to get a second set of eyes on whether this is the expected result or not before I dive into debugging + fixing it.
Also, it would be nice if we could verify that my understanding of how Cranelift's stack maps are supposed to work is correct in the new doc comments.
@eqrion, could you take a look at this please? Thanks!
Wasmtime GitHub notifications bot (Jun 08 2020 at 22:58):fitzgen has marked PR #1824 as ready for review.
Wasmtime GitHub notifications bot (Jun 08 2020 at 22:58):fitzgen merged PR #1824.
Last updated: Nov 22 2024 at 17:03 UTC