Stream: git-wasmtime

Topic: wasmtime / PR #1820 Implement fcvt_to_sint_sat (f32x4 -> ...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 17:11):

abrown opened PR #1820 from f32x4-to-i32x4 to master:

This is a follow-on to #1765 and should be merged after that PR. The most notable change here is the addition of the ISA-specific flags assert_no_nans and assert_in_bounds which are disabled by default; when enabled they allow Cranelift to reduce the cost (in number of instructions) of lowering this and other SIMD instructions.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 17:11):

abrown requested bnjbvr for a review on PR #1820.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 17:23):

abrown has marked PR #1820 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 17:36):

abrown edited PR #1820 from f32x4-to-i32x4 to master:

This is a follow-on to #1765 and should be merged after that PR.

The most notable change here is the addition of the ISA-specific flags assert_no_nans and assert_in_bounds which are disabled by default; when enabled they allow Cranelift to reduce the cost (in number of instructions) of lowering this and other SIMD instructions.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 13:15):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 23:08):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 23:08):

abrown created PR Review Comment:

Can be removed per https://bytecodealliance.zulipchat.com/#narrow/stream/217117-cranelift/topic/SIMD/near/200302379

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 23:41):

sunfishcode submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2020 at 23:41):

sunfishcode created PR Review Comment:

Looking at this more, I think the and is needed, but the operand of the and should be cmpeqps(arg, arg), not all ones.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2020 at 22:23):

abrown closed without merge PR #1820.


Last updated: Dec 23 2024 at 12:05 UTC