yurydelendik opened PR #1819 from gimli-0.21
to master
:
- Updates version
- Hack for non-serializable Expression
- Remove .debug_frame writing
yurydelendik requested fitzgen for a review on PR #1819.
fitzgen submitted PR Review.
fitzgen created PR Review Comment:
This looks like it is purely delegating to
EndianVec<RunTimeEndian>
, which already implementsWriter
, so why are we wrapping it, instead of using it directly?
fitzgen submitted PR Review.
fitzgen created PR Review Comment:
I'm actually not 100% sure who is not generating what, but if I guessed it correctly, then this would clear things up a bit:
// Cranelift's unwind support does not generate `CallFrameInstruction`s with
yurydelendik updated PR #1819 from gimli-0.21
to master
:
- Updates version
- Hack for non-serializable Expression
- Remove .debug_frame writing
yurydelendik submitted PR Review.
yurydelendik created PR Review Comment:
Nice to know, thanks! I removed this portion of the code in favor of not dealing with
Expression
serialization at all.
yurydelendik merged PR #1819.
Last updated: Dec 23 2024 at 13:07 UTC