Stream: git-wasmtime

Topic: wasmtime / PR #1819 Upgrade gimli to 0.21

Wasmtime GitHub notifications bot (Jun 04 2020 at 16:16):

yurydelendik opened PR #1819 from gimli-0.21 to master:

• Updates version
• Hack for non-serializable Expression
• Remove .debug_frame writing

Wasmtime GitHub notifications bot (Jun 04 2020 at 16:18):

yurydelendik requested fitzgen for a review on PR #1819.

Wasmtime GitHub notifications bot (Jun 04 2020 at 16:45):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jun 04 2020 at 16:45):

fitzgen created PR Review Comment:

This looks like it is purely delegating to EndianVec<RunTimeEndian>, which already implements Writer, so why are we wrapping it, instead of using it directly?

Wasmtime GitHub notifications bot (Jun 04 2020 at 16:45):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Jun 04 2020 at 16:45):

fitzgen created PR Review Comment:

I'm actually not 100% sure who is not generating what, but if I guessed it correctly, then this would clear things up a bit:

                // Cranelift's unwind support does not generate `CallFrameInstruction`s with

Wasmtime GitHub notifications bot (Jun 04 2020 at 18:03):

yurydelendik updated PR #1819 from gimli-0.21 to master:

• Updates version
• Hack for non-serializable Expression
• Remove .debug_frame writing

Wasmtime GitHub notifications bot (Jun 04 2020 at 18:05):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Jun 04 2020 at 18:05):

yurydelendik created PR Review Comment:

Nice to know, thanks! I removed this portion of the code in favor of not dealing with Expression serialization at all.

Wasmtime GitHub notifications bot (Jun 04 2020 at 19:34):

yurydelendik merged PR #1819.

Last updated: Nov 22 2024 at 16:03 UTC