Stream: git-wasmtime

Topic: wasmtime / PR #1817 Avoid touching encodings in `EncCurso...

Wasmtime GitHub notifications bot (Jun 04 2020 at 00:03):

cfallin opened PR #1817 from issue-1809 to master:

EncCursor is a variant of Cursor that allows updating CLIF while
keeping its encodings up to date, given a particular ISA. However, new
(MachInst) backends don't use the encodings, and the TargetIsaAdapter
shim will panic if any encoding-related method is called. This PR avoids
those panics.

Fixes #1809.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 04 2020 at 00:03):

cfallin requested bnjbvr for a review on PR #1817.

Wasmtime GitHub notifications bot (Jun 04 2020 at 08:33):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Jun 04 2020 at 08:33):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Jun 04 2020 at 08:33):

bnjbvr created PR Review Comment:

nit: we can drop the negation and use is_none here

Wasmtime GitHub notifications bot (Jun 04 2020 at 17:53):

cfallin updated PR #1817 from issue-1809 to master:

EncCursor is a variant of Cursor that allows updating CLIF while
keeping its encodings up to date, given a particular ISA. However, new
(MachInst) backends don't use the encodings, and the TargetIsaAdapter
shim will panic if any encoding-related method is called. This PR avoids
those panics.

Fixes #1809.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 04 2020 at 19:50):

cfallin merged PR #1817.

Last updated: Dec 23 2024 at 12:05 UTC