Wasmtime GitHub notifications bot (Jun 03 2020 at 16:35): Wasmtime GitHub notifications bot (Jun 03 2020 at 16:35):cfallin opened PR #1811 from fix-warning to master:
Should fix recent build failures on CI.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 03 2020 at 16:36):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Jun 03 2020 at 16:38):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Jun 03 2020 at 16:48):cfallin updated PR #1811 from fix-warning to master:
Should fix recent build failures on CI.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 03 2020 at 19:04):cfallin updated PR #1811 from fix-warning to master:
Should fix recent build failures on CI.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 03 2020 at 19:10):yurydelendik updated PR #1811 from fix-warning to master:
Should fix recent build failures on CI.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 03 2020 at 19:20):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jun 03 2020 at 19:20):alexcrichton created PR Review Comment:
Instead of checking in an
=dependency could we leave the lock file as what's a known good version to test against? That would basically just involve dropping this from the diff. I can look into what's going on with the most recent version of backtrace soon too hopefully.
Wasmtime GitHub notifications bot (Jun 03 2020 at 19:25):yurydelendik submitted PR Review.
Wasmtime GitHub notifications bot (Jun 03 2020 at 19:25):yurydelendik created PR Review Comment:
yep, I used version "0.3.46" from Cargo.lock
Wasmtime GitHub notifications bot (Jun 03 2020 at 19:27):cfallin updated PR #1811 from fix-warning to master:
Should fix recent build failures on CI.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 03 2020 at 19:27):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Jun 03 2020 at 19:27):cfallin created PR Review Comment:
Sure, just amended the commit to remove that.
Wasmtime GitHub notifications bot (Jun 03 2020 at 19:47):cfallin updated PR #1811 from fix-warning to master:
Should fix recent build failures on CI.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 03 2020 at 20:26):cfallin merged PR #1811.
Last updated: Oct 23 2024 at 20:03 UTC