Wasmtime GitHub notifications bot (Jun 03 2020 at 16:21): Wasmtime GitHub notifications bot (Jun 03 2020 at 16:21):3miliano opened PR #1810 from fix/test-programs-tagged-unions to master:
This PR adapts test-programs code to use the new tagged-unions generated code of wasi. Note that wasi dependency has not been updated, we should release a wasi 0.9.1 (which includes the tagged-unions generated code) and adapt this dependency accordingly to the newly generated code.
If you want to test this locally, you can use the master release of wasi and change the dependency to use your local copy.
Wasmtime GitHub notifications bot (Jun 03 2020 at 16:22):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Jun 03 2020 at 16:22):bjorn3 created PR Review Comment:
nit: missing trailing newline
Wasmtime GitHub notifications bot (Jun 03 2020 at 18:47):3miliano updated PR #1810 from fix/test-programs-tagged-unions to master:
This PR adapts test-programs code to use the new tagged-unions generated code of wasi. Note that wasi dependency has not been updated, we should release a wasi 0.9.1 (which includes the tagged-unions generated code) and adapt this dependency accordingly to the newly generated code.
If you want to test this locally, you can use the master release of wasi and change the dependency to use your local copy.
Wasmtime GitHub notifications bot (Jun 03 2020 at 18:50):3miliano submitted PR Review.
Wasmtime GitHub notifications bot (Jun 03 2020 at 18:50):3miliano created PR Review Comment:
corrected
Wasmtime GitHub notifications bot (Jun 03 2020 at 21:17):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jun 03 2020 at 21:17):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Jun 03 2020 at 21:17):alexcrichton created PR Review Comment:
We currently intentionally check in the lock file, so mind removing this file?
Wasmtime GitHub notifications bot (Jun 03 2020 at 22:01):3miliano submitted PR Review.
Wasmtime GitHub notifications bot (Jun 03 2020 at 22:01):3miliano created PR Review Comment:
Of course. I thought it was an oversight. I'll remove the gitignore.
Wasmtime GitHub notifications bot (Jun 03 2020 at 22:09):3miliano updated PR #1810 from fix/test-programs-tagged-unions to master:
This PR adapts test-programs code to use the new tagged-unions generated code of wasi. Note that wasi dependency has not been updated, we should release a wasi 0.9.1 (which includes the tagged-unions generated code) and adapt this dependency accordingly to the newly generated code.
If you want to test this locally, you can use the master release of wasi and change the dependency to use your local copy.
Wasmtime GitHub notifications bot (Jun 03 2020 at 23:01):3miliano updated PR #1810 from fix/test-programs-tagged-unions to master:
This PR adapts test-programs code to use the new tagged-unions generated code of wasi. Note that wasi dependency has not been updated, we should release a wasi 0.9.1 (which includes the tagged-unions generated code) and adapt this dependency accordingly to the newly generated code.
If you want to test this locally, you can use the master release of wasi and change the dependency to use your local copy.
Wasmtime GitHub notifications bot (Jun 04 2020 at 00:29):pchickey merged PR #1810.
Last updated: Dec 23 2024 at 13:07 UTC