3miliano opened PR #1810 from fix/test-programs-tagged-unions
to master
:
This PR adapts test-programs code to use the new tagged-unions generated code of wasi. Note that wasi dependency has not been updated, we should release a wasi 0.9.1 (which includes the tagged-unions generated code) and adapt this dependency accordingly to the newly generated code.
If you want to test this locally, you can use the master release of wasi and change the dependency to use your local copy.
bjorn3 submitted PR Review.
bjorn3 created PR Review Comment:
nit: missing trailing newline
3miliano updated PR #1810 from fix/test-programs-tagged-unions
to master
:
This PR adapts test-programs code to use the new tagged-unions generated code of wasi. Note that wasi dependency has not been updated, we should release a wasi 0.9.1 (which includes the tagged-unions generated code) and adapt this dependency accordingly to the newly generated code.
If you want to test this locally, you can use the master release of wasi and change the dependency to use your local copy.
3miliano submitted PR Review.
3miliano created PR Review Comment:
corrected
alexcrichton submitted PR Review.
alexcrichton submitted PR Review.
alexcrichton created PR Review Comment:
We currently intentionally check in the lock file, so mind removing this file?
3miliano submitted PR Review.
3miliano created PR Review Comment:
Of course. I thought it was an oversight. I'll remove the gitignore.
3miliano updated PR #1810 from fix/test-programs-tagged-unions
to master
:
This PR adapts test-programs code to use the new tagged-unions generated code of wasi. Note that wasi dependency has not been updated, we should release a wasi 0.9.1 (which includes the tagged-unions generated code) and adapt this dependency accordingly to the newly generated code.
If you want to test this locally, you can use the master release of wasi and change the dependency to use your local copy.
3miliano updated PR #1810 from fix/test-programs-tagged-unions
to master
:
This PR adapts test-programs code to use the new tagged-unions generated code of wasi. Note that wasi dependency has not been updated, we should release a wasi 0.9.1 (which includes the tagged-unions generated code) and adapt this dependency accordingly to the newly generated code.
If you want to test this locally, you can use the master release of wasi and change the dependency to use your local copy.
pchickey merged PR #1810.
Last updated: Nov 22 2024 at 17:03 UTC