Stream: git-wasmtime

Topic: wasmtime / PR #1807 Fix warning

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 14:04):

sunfishcode opened PR #1807 from fix-warning to master:

The Wasmtime publishing scripts run cargo update, which upgraded Wasmtime's region dependency from 2.1.0 to 2.2.0. In 2.2.0, region deprecated region::Protection::ReadExecute and added region::Protection::READ_EXECUTE. Adding new things is compatible with a minor version bump, and my local build and cargo publish verifiation didn't get errors, however since our CI builds with warnings-as-errors, the CI is now red.

This PR fixes the warning, which should fix error.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 14:05):

sunfishcode updated PR #1807 from fix-warning to master:

The Wasmtime publishing scripts run cargo update, which upgraded Wasmtime's region dependency from 2.1.0 to 2.2.0. In 2.2.0, region deprecated region::Protection::ReadExecute and added region::Protection::READ_EXECUTE. Adding new things is compatible with a minor version bump, and my local build and cargo publish verifiation didn't get errors, however since our CI builds with warnings-as-errors, the CI is now red.

This PR fixes the warning, which should fix error.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 14:05):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 19:24):

sunfishcode closed without merge PR #1807.

Last updated: Dec 23 2024 at 12:05 UTC