Wasmtime GitHub notifications bot (Jun 01 2020 at 08:08): Wasmtime GitHub notifications bot (Jun 01 2020 at 08:08):jlb6740 opened PR #1797 from vcode-mul-div-max-min to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 01 2020 at 18:33):jlb6740 updated PR #1797 from vcode-mul-div-max-min to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 01 2020 at 18:40):jlb6740 has marked PR #1797 as ready for review.
Wasmtime GitHub notifications bot (Jun 02 2020 at 15:47):bnjbvr requested julian-seward1 for a review on PR #1797.
Wasmtime GitHub notifications bot (Jun 07 2020 at 07:44):julian-seward1 submitted PR Review.
Wasmtime GitHub notifications bot (Jun 07 2020 at 07:44):julian-seward1 submitted PR Review.
Wasmtime GitHub notifications bot (Jun 07 2020 at 07:44):julian-seward1 created PR Review Comment:
A quick sanity check: for the min/max operations, does this provide the correct semantics for the unordered case relative to what CLIR requires?
Wasmtime GitHub notifications bot (Jun 11 2020 at 04:27):jlb6740 updated PR #1797 from vcode-mul-div-max-min to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 11 2020 at 06:05):jlb6740 updated PR #1797 from vcode-mul-div-max-min to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 11 2020 at 06:07):jlb6740 updated PR #1797 from vcode-mul-div-max-min to master:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 11 2020 at 12:20):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Jun 11 2020 at 12:20):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Jun 11 2020 at 12:20):bnjbvr created PR Review Comment:
In order to help getting this landed, I checked, and the answer is no: in the old backend, fmax goes through
expand_minmaxwhich does more complicated things using the x86's min and max (also for 0 and -0, etc.). So this needs a bit of re-work.
Last updated: Nov 22 2024 at 16:03 UTC